script to modify the state history retention period via the safe sdk #2012
+170
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysiahuggins
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
…in-via-the-safe-sdk
…in-via-the-safe-sdk
Sneh1999
reviewed
Sep 17, 2024
| * @param {string} value - The value to be sent with the transaction | ||
| * @returns {Promise<any>} - A promise that resolves to the Safe transaction object | ||
| */ | ||
| async function createSafeTransaction( |
There was a problem hiding this comment.
we could move this to utils.ts as it can be used by other files in the future
| ); | ||
|
|
||
| console.log( | ||
| `The other owners of the Safe Multisig wallet need to sign the transaction via the Safe UI https://app.safe.global/transactions/queue?safe=sep:${safeAddress}`, |
There was a problem hiding this comment.
nit: Proposal created successfully. The other owners of the Safe Multisig wallet need to sign the transaction via the Safe UI https://app.safe.global/transactions/queue?safe=sep:${safeAddress}
| * @param {number} retention_period - The state history retention period in seconds | ||
| * @returns {string} - Encoded transaction data | ||
| */ | ||
| function createStateHistoryRetentionPeriodTxData(retention_period: number): string { |
There was a problem hiding this comment.
nit: does this have to be a function? it is just two lines so we can prob merge this with proposeSetStateHistoryRetentionTransaction
| ): Promise<LocalSafeTransaction> { | ||
| // Prepare the safe transaction data with the contract address, data, and value | ||
| let safeTransactionData = createSafeTransactionData(contractAddress, data, value); | ||
| console.log("data hex: ", data); |
There was a problem hiding this comment.
console.log("Safe Transaction Data hex: ", data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2008
This PR: