Support maplibre-gl v4
#219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
gavinr-maps
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Looks good. As mentioned, basically the same as how we handled it in #201.
|
Additional info: This has also passed out internal QA testing with the latest versions of Granted we may not use all provided features. |
|
Hi there, thanks for keeping the dependencies up to date! Are there plans on merging this change and releasing a new version in the near future? Thanks again! |
|
@pflopez Thanks for checking and thanks for your patience. I'm hoping to get this reviewed and released next week! |
|
This was released in v4.2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't done much more than #201 did
Just updated the peerDependency, and made sure v4 is resolved in the lockfile.
Test results – though I'm not sure the
maplibre-glintegration is actually covered by tests: