Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of 'css-unused-selector' warning messages #332

Closed
EthanThatOneKid opened this issue Mar 12, 2022 · 0 comments · Fixed by #333
Closed

Lots of 'css-unused-selector' warning messages #332

EthanThatOneKid opened this issue Mar 12, 2022 · 0 comments · Fixed by #333
Labels
bug Something isn't working devops Some operation must be executed
Milestone

Comments

@EthanThatOneKid
Copy link
Owner

EthanThatOneKid commented Mar 12, 2022

What happened?

The only places on the site where we should be overfitting CSS class declarations is on pages with unexpected HTML content, such as the blog post pages. However, we see a many unused CSS selectors coming from our theme.scss file that contains helper classes for sizing using a third-party library, rfs. These helper classes can be rewritten on each component where it is needed since it merely requires the SCSS mixin from the 3rd party rfs library.

Screenshot

image

Suggested by @MohamedHabarneh during the first acmDev meeting of our Spring 2022 sprint.

@EthanThatOneKid EthanThatOneKid added bug Something isn't working devops Some operation must be executed labels Mar 12, 2022
@EthanThatOneKid EthanThatOneKid added this to the v3.0 🌞 milestone Mar 12, 2022
@ghost ghost closed this as completed in #333 Mar 16, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops Some operation must be executed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant