Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved annoying 'css-unused-selector' warning messages #333

Merged
12 commits merged into from
Mar 16, 2022
Merged

Resolved annoying 'css-unused-selector' warning messages #333

12 commits merged into from
Mar 16, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Mar 12, 2022

  • Deleted theme.scss file
  • Added size variables to global.css
  • Replaced RFS library with CSS calc()-ulations in global.css
  • Removed gfm.css (GitHub Flavored Markdown) CSS library

Resolves #332.

@EthanThatOneKid EthanThatOneKid added enhancement New feature or request developer experience Enhancement geared towards the devs labels Mar 12, 2022
@EthanThatOneKid EthanThatOneKid requested review from a user and MohamedHabarneh March 12, 2022 10:17
@vercel
Copy link

vercel bot commented Mar 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/2BYsXM4dYk1VUF7UYpta1R3DH85H
✅ Preview: https://acm-csuf-site-git-fix-332-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview March 12, 2022 10:19 Inactive
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfs package doesn't resize some headers to become smaller on mobile breakpoint like before, but tbh i kinda like it. approved

image

@vercel vercel bot temporarily deployed to Preview March 13, 2022 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview March 13, 2022 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview March 14, 2022 23:49 Inactive
@vercel vercel bot temporarily deployed to Preview March 15, 2022 00:07 Inactive
@EthanThatOneKid EthanThatOneKid requested a review from a user March 15, 2022 00:31
@EthanThatOneKid
Copy link
Owner Author

EthanThatOneKid commented Mar 15, 2022

rfs package doesn't resize some headers to become smaller on mobile breakpoint like before, but tbh i kinda like it. approved

I added the RFS-generated values to our global.css since we don't need to recalculate them.

@media screen and (max-width: 1000px) {
:root {
--size-xl: calc(1.425rem + 2.1vw);
--size-lg: calc(1.35rem + 1.2vw);
--size-md: calc(1.275rem + 0.3vw);
--size-sm: calc(1.175rem + 0.1vw);
--size-xs: calc(1.075rem + 0.05vw);
}
}

Updated Screenshot

image

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join button text should be a big larger for desktop
image

Hover on join button is different now. The background color should be changing to acmBlue, not the text color.

@ghost ghost merged commit b62da22 into main Mar 16, 2022
@jaasonw jaasonw deleted the fix/332 branch September 7, 2022 07:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Enhancement geared towards the devs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of 'css-unused-selector' warning messages
2 participants