Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add theme logic to error page #1009

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

noahbei
Copy link
Collaborator

@noahbei noahbei commented Dec 28, 2023

Fixes the issue mentioned in #971
I don't know if the fix is the most optimal way to do it because I just put the code from the +layout.svelte in (site) into the outer +error.svelte

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit c98b0eb
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/65f27c557b22a6000821c508
😎 Deploy Preview https://deploy-preview-1009--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EthanThatOneKid EthanThatOneKid linked an issue Mar 14, 2024 that may be closed by this pull request
@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) March 14, 2024 04:25
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm (using the preview) that toggling the color preference is now possible from the error page. Nice work, @noahbei!!! Thanks, man 😎

@EthanThatOneKid EthanThatOneKid merged commit 54761e5 into EthanThatOneKid:main Mar 14, 2024
5 checks passed
@EthanThatOneKid EthanThatOneKid removed the request for review from tomasohCHOM March 14, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light/Dark mode toggle not working on 404 page
2 participants