Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify acm-select.svelte to create a custom select dropdown #156

Merged
merged 4 commits into from
Oct 25, 2021
Merged

Modify acm-select.svelte to create a custom select dropdown #156

merged 4 commits into from
Oct 25, 2021

Conversation

anhduy1202
Copy link
Collaborator

Hi, can you check the design as well as the code for my custom select dropdown? Thanks

@anhduy1202 anhduy1202 requested review from EthanThatOneKid and a user October 23, 2021 23:16
@vercel
Copy link

vercel bot commented Oct 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/3bBEsBmF1PGfMboBnaLxwdjc9FUA
✅ Preview: https://acm-csuf-site-git-fork-anhduy1202-edit-a-f5f5d6-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview October 23, 2021 23:16 Inactive
EthanThatOneKid
EthanThatOneKid requested changes Oct 23, 2021
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component itself looks nice! I added some requests and comments for you.

src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview October 24, 2021 04:08 Inactive
EthanThatOneKid
EthanThatOneKid requested changes Oct 24, 2021
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few more nitpicks with some more notes on the CSS. Keep up the great work; this is becoming a pretty solid Svelte component!

src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
src/lib/components/utils/acm-select.svelte Outdated Show resolved Hide resolved
@EthanThatOneKid EthanThatOneKid linked an issue Oct 24, 2021 that may be closed by this pull request
Fine-tune acm-select.svelte CSS ▶ #47
Closed
@vercel vercel bot temporarily deployed to Preview October 24, 2021 17:29 Inactive
@EthanThatOneKid EthanThatOneKid added the good first issue Good for newcomers label Oct 24, 2021
@vercel vercel bot temporarily deployed to Preview October 25, 2021 01:18 Inactive
EthanThatOneKid
EthanThatOneKid approved these changes Oct 25, 2021
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solid, 88-lined custom select component looks good to me! Feel free to squash and merge your PR whenever you're ready, @anhduy1202.

@anhduy1202 anhduy1202 merged commit 1aec8dd into EthanThatOneKid:main Oct 25, 2021
@anhduy1202 anhduy1202 deleted the edit/acm-select.svelte branch October 25, 2021 01:30
@EthanThatOneKid EthanThatOneKid mentioned this pull request Nov 7, 2021
Closed
@EthanThatOneKid EthanThatOneKid removed the request for review from a user December 8, 2021 01:56
@EthanThatOneKid EthanThatOneKid added the enhancement New feature or request label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamondburned diamondburned diamondburned left review comments

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fine-tune acm-select.svelte CSS ▶
3 participants
@anhduy1202 @diamondburned @EthanThatOneKid