Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed navigation tab bug #163

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fixed navigation tab bug #163

merged 1 commit into from
Oct 28, 2021

Conversation

dustinchavez1
Copy link
Contributor

  • Changed instances of slug to path
  • Changed conditional logic for aria-current attribute
  • Using new page store from svelte kit

@vercel
Copy link

vercel bot commented Oct 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/CJWUS4uoq6gNTe8YXKYUqtGnAmzf
✅ Preview: https://acm-csuf-site-git-fix-150-ethanthatonekid.vercel.app

EthanThatOneKid
EthanThatOneKid approved these changes Oct 28, 2021
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great!

@dustinchavez1 dustinchavez1 merged commit 6422f28 into main Oct 28, 2021
@EthanThatOneKid EthanThatOneKid mentioned this pull request Nov 7, 2021
Closed
@EthanThatOneKid EthanThatOneKid added the bugfix A PR that fixes a bug label Dec 8, 2021
@jaasonw jaasonw deleted the fix/150 branch February 21, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
bugfix A PR that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustinchavez1 @EthanThatOneKid