Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Frank to 404 page #176

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Added Frank to 404 page #176

merged 1 commit into from
Oct 30, 2021

Conversation

adityashah6
Copy link
Contributor

Added Frank to 404 page. Resolves #118.

@vercel
Copy link

vercel bot commented Oct 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/m8emvariw3Kx1apQyCw14gUpV5Pv
✅ Preview: https://acm-csuf-site-git-fix-118-ethanthatonekid.vercel.app

EthanThatOneKid
EthanThatOneKid approved these changes Oct 30, 2021
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are awaiting official 404 Page designs from ✨acmCreate✨, but this is a great placeholder for now! Once those designs are published, we just have to tweak the src attribute.

@adityashah6 adityashah6 merged commit 363fccc into main Oct 30, 2021
@EthanThatOneKid EthanThatOneKid mentioned this pull request Oct 31, 2021
Closed
@EthanThatOneKid EthanThatOneKid added the bugfix A PR that fixes a bug label Dec 8, 2021
@jaasonw jaasonw deleted the fix/118 branch February 21, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
bugfix A PR that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement 404 page design 🟥
2 participants
@adityashah6 @EthanThatOneKid