Refactored Spacing component to use CSS variables #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://svelte.dev/docs#style_props>. Attempts to close #158.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/8L6oH4BDRWZ8TZb4bGbVpUYrbrqx |
diamondburned
approved these changes
Nov 2, 2021
diamondburned
added a commit
that referenced
this pull request
Nov 3, 2021
This commit fixes the Spacing component's CSS variables being incorrectly set. They didn't work prior to this change, because of a regression from PR #184.
EthanThatOneKid
pushed a commit
that referenced
this pull request
Nov 3, 2021
This commit fixes the Spacing component's CSS variables being incorrectly set. They didn't work prior to this change, because of a regression from PR #184.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the
<Spacing />component to use CSS variables (https://svelte.dev/docs#style_props) instead ofuse:stylePropsso that the component no longer relies on any JavaScript.Attempts to close #158, at least temporarily.