Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted strange spacing in various places #233

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

EthanThatOneKid
Copy link
Owner

Background

Found in @mikeploythai's #226 (review).

Before

image

After

image

@EthanThatOneKid EthanThatOneKid requested a review from a user November 18, 2021 04:41
@vercel
Copy link

vercel bot commented Nov 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/A5GSTuLmtDVBWmivJHUE3ERcPhX2
✅ Preview: https://acm-csuf-site-git-adjust-homepage-spacing-ethanthatonekid.vercel.app

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the spacing issue for the components, but now the button gap is back on the viewport dimensions of my PC monitor, but not my laptop viewport. Strange behavior

image

@EthanThatOneKid
Copy link
Owner Author

This fixed the spacing issue for the components, but now the button gap is back on the viewport dimensions of my PC monitor, but not my laptop viewport. Strange behavior

image

I'd say the behavior is strange due to lack of testing. More finetuning is definitely needed in some places. I'll pivot this PR into a general fix to clean up as many of these hidden fixes as we can find. Thanks for noting that.

@EthanThatOneKid EthanThatOneKid changed the title Adjusted spacing around navbar on homepage Adjusted strange spacing in various places Nov 18, 2021
@vercel vercel bot temporarily deployed to Preview November 18, 2021 05:17 Inactive
@EthanThatOneKid EthanThatOneKid merged commit bd93d1f into main Nov 18, 2021
@EthanThatOneKid EthanThatOneKid added the bugfix A PR that fixes a bug label Dec 8, 2021
@jaasonw jaasonw deleted the adjust-homepage-spacing branch February 21, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant