Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Size Limit for node_modules #248

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Added Size Limit for node_modules #248

merged 2 commits into from
Jan 17, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Dec 21, 2021

I used this NPM package, ai/size-limit, to help with calculating the size of our node_modules directory after a clean npm i. The size of fix/247's node_modules was clocked at 39.91 MB gzipped (according to run 4835296416), so I set the threshold to 50 MB as a starting point.

As we change our package.json, we should also contemplate and refer to the threshold in our package.json. If anything, we'd like to eventually lower the threshold as time goes on.

Resolves #247.

@EthanThatOneKid EthanThatOneKid added enhancement New feature or request devops Some operation must be executed bugfix A PR that fixes a bug labels Dec 21, 2021
@vercel
Copy link

vercel bot commented Dec 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/8ehrVRzRDETxbrZrne81aeGsNMh4
✅ Preview: https://acm-csuf-site-git-fix-247-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview January 17, 2022 01:17 Inactive
Copy link
Collaborator

@diamondburned diamondburned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving the approval for this PR, though it's not the best idea that the limiting metric is the overall modules size and not tree size or whatnot. Something is better than nothing, though.

@EthanThatOneKid EthanThatOneKid merged commit a1b07b5 into main Jan 17, 2022
@jaasonw jaasonw deleted the fix/247 branch February 21, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug devops Some operation must be executed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a size limit for our NPM dependencies
2 participants