-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added privacy policy page #255
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/BAYgSbaQwNDfbE37KKThB2Ks4xng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Intro
Change "acmCSUF's Privacy Policy" to "Our privacy policy", capitalize Discord.
// Headers
Lowercase "Collect", "Information", "Retention", "Data Rights and Choices", "Privacy Policy", and "Us" in its respective headers
On every H2, add class="headers" to change the weight of the headers to slimmer. According to the design guidelines, bold/font weight 700 is reserved only for the following keywords: CSUF, Path Names, and the Color Palette
Change the font-weight for "Information you provide" and "Data we collect automatically" to 500 to adhere to the design guidelines
Do we have acmcsuf@gmail.com?
Done.
Done; I kept the proper capitalization in the markup, but I made the text visually lower-cased with the
Done and done. Is there a link you could share in reference to the design guidelines you speak of?
Good catch! I corrected this to acmcsufullerton@gmail.com. I will request a re-review now. Thanks! |
With this, I meant rather than Information we CollectChange it to Information we collectThe first word will always be uppercased, just like a normal sentence. So with that said, all the headers should be stylized as Welcome to ACM!Information we collectOur use of your informationData retentionYour data rights and choicesChanges to this privacy policyContacting us |
I see what you mean! Alright, I fixed that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added the privacy policy page based on the most recent version created by the acmCSUF board.
Resolves #254.
Preview: https://acm-csuf-site-git-fix-254-ethanthatonekid.vercel.app/privacy.