Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added privacy policy page #255

Merged
merged 6 commits into from
Jan 22, 2022
Merged

Added privacy policy page #255

merged 6 commits into from
Jan 22, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Jan 20, 2022

I added the privacy policy page based on the most recent version created by the acmCSUF board.

Resolves #254.
Preview: https://acm-csuf-site-git-fix-254-ethanthatonekid.vercel.app/privacy.

@EthanThatOneKid EthanThatOneKid added the enhancement New feature or request label Jan 20, 2022
@EthanThatOneKid EthanThatOneKid requested a review from a user January 20, 2022 02:36
@vercel
Copy link

vercel bot commented Jan 20, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/BAYgSbaQwNDfbE37KKThB2Ks4xng
✅ Preview: https://acm-csuf-site-git-fix-254-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview January 20, 2022 03:28 Inactive
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Intro
Change "acmCSUF's Privacy Policy" to "Our privacy policy", capitalize Discord.

// Headers
Lowercase "Collect", "Information", "Retention", "Data Rights and Choices", "Privacy Policy", and "Us" in its respective headers

On every H2, add class="headers" to change the weight of the headers to slimmer. According to the design guidelines, bold/font weight 700 is reserved only for the following keywords: CSUF, Path Names, and the Color Palette

Change the font-weight for "Information you provide" and "Data we collect automatically" to 500 to adhere to the design guidelines

Do we have acmcsuf@gmail.com?

@vercel vercel bot temporarily deployed to Preview January 20, 2022 18:35 Inactive
@vercel vercel bot temporarily deployed to Preview January 20, 2022 19:26 Inactive
@EthanThatOneKid
Copy link
Owner Author

// Intro Change "acmCSUF's Privacy Policy" to "Our privacy policy", capitalize Discord.

Done.

// Headers Lowercase "Collect", "Information", "Retention", "Data Rights and Choices", "Privacy Policy", and "Us" in its respective headers

Done; I kept the proper capitalization in the markup, but I made the text visually lower-cased with the text-transform: lowercase CSS property.

On every H2, add class="headers" to change the weight of the headers to slimmer. According to the design guidelines, bold/font weight 700 is reserved only for the following keywords: CSUF, Path Names, and the Color Palette

Change the font-weight for "Information you provide" and "Data we collect automatically" to 500 to adhere to the design guidelines

Done and done. Is there a link you could share in reference to the design guidelines you speak of?

Do we have acmcsuf@gmail.com?

Good catch! I corrected this to acmcsufullerton@gmail.com.

I will request a re-review now. Thanks!

@EthanThatOneKid EthanThatOneKid requested a review from a user January 20, 2022 19:31
@ghost
Copy link

ghost commented Jan 21, 2022

Done; I kept the proper capitalization in the markup, but I made the text visually lower-cased with the text-transform: lowercase CSS property.

With this, I meant rather than

Information we Collect

Change it to

Information we collect

The first word will always be uppercased, just like a normal sentence.


So with that said, all the headers should be stylized as

Welcome to ACM!

Information we collect

Our use of your information

Data retention

Your data rights and choices

Changes to this privacy policy

Contacting us

@EthanThatOneKid
Copy link
Owner Author

Done; I kept the proper capitalization in the markup, but I made the text visually lower-cased with the text-transform: lowercase CSS property.

With this, I meant rather than

Information we Collect

Change it to

Information we collect

The first word will always be uppercased, just like a normal sentence.

I see what you mean! Alright, I fixed that too.

@vercel vercel bot temporarily deployed to Preview January 22, 2022 04:06 Inactive
@vercel vercel bot temporarily deployed to Preview January 22, 2022 04:08 Inactive
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EthanThatOneKid EthanThatOneKid merged commit 94781ea into main Jan 22, 2022
@jaasonw jaasonw deleted the fix/254 branch February 21, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new page containing our club's privacy policy
1 participant