Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Join from new tab #293

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Events: Join from new tab #293

merged 1 commit into from
Feb 13, 2022

Conversation

EthanThatOneKid
Copy link
Owner

Upon clicking a "Join" button, the join link is opened in a new tab using target="_blank".

Resolves #292.

Upon clicking a "Join" button, the join link is opened in a new tab using `target="_blank"`.
@vercel
Copy link

vercel bot commented Feb 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/5WjPi3qWwtzU84DrK2DAsuLKKmW6
✅ Preview: https://acm-csuf-site-git-events-join-new-tab-ethanthatonekid.vercel.app

Copy link
Contributor

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works, technically noopener noreferrer is default behavior in all modern browsers now but it doesn't hurt to be safe

https://chromestatus.com/feature/6140064063029248

@EthanThatOneKid EthanThatOneKid merged commit 3226cdf into main Feb 13, 2022
@jaasonw jaasonw deleted the events/join-new-tab branch February 21, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events: Clicking "Join" navigates to 404
2 participants