Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Svelte style directive where applicable #353

Merged
34 commits merged into from
Mar 26, 2022
Merged

Conversation

EthanThatOneKid
Copy link
Owner

A recent Svelte release added a new style directive that simplifies some code that otherwise looks pretty gross. This PR is an attempt at keeping the codebase up-to-date with the latest Svelte capabilities.

More info: https://geoffrich.net/posts/style-directives/.

Recommended to wait on this <sveltejs/kit#4118 (comment)>
Recommended to wait on this <sveltejs/kit#4118 (comment)>
@EthanThatOneKid EthanThatOneKid added the enhancement New feature or request label Mar 19, 2022
@vercel
Copy link

vercel bot commented Mar 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/24cYDP4HbVmpGaapNXxP5pWuzvvN
✅ Preview: https://acm-csuf-site-git-play-style-directive-1-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview March 19, 2022 22:42 Inactive
Copy link
Collaborator

@JustinStitt JustinStitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
style:lgtm={lgtm}

@vercel vercel bot temporarily deployed to Preview March 26, 2022 22:36 Inactive
@EthanThatOneKid EthanThatOneKid requested a review from a user March 26, 2022 22:39
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I should really read the Svelte docs for once lmao

@vercel vercel bot temporarily deployed to Preview March 26, 2022 23:01 Inactive
@ghost ghost merged commit b783503 into main Mar 26, 2022
@ghost ghost deleted the play/style-directive-1 branch April 17, 2022 17:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants