Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Birth of parseBool() #455

Merged
merged 26 commits into from
Aug 29, 2022
Merged

Birth of parseBool() #455

merged 26 commits into from
Aug 29, 2022

Commits on Apr 28, 2022

  1. added common util folder, implemented isStringTruthy, added isPinned … 

    …to acmEvent
    @mle225
    mle225 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    af96814 View commit details
    Browse the repository at this point in the history

  2. cast DEBUG to string to check

    @mle225
    mle225 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    93dcbde View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Update isStringTruthy function signature 

    Co-authored-by: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
    @mle225 @EthanThatOneKid
    mle225 and EthanThatOneKid committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    9a02c7a View commit details
    Browse the repository at this point in the history

  2. Update isStringTruthy truthy check 

    Co-authored-by: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
    @mle225 @EthanThatOneKid
    mle225 and EthanThatOneKid committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    0b6bc9f View commit details
    Browse the repository at this point in the history

  3. Update src/lib/common/utils.ts 

    Co-authored-by: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
    @mle225 @EthanThatOneKid
    mle225 and EthanThatOneKid committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    030f1b2 View commit details
    Browse the repository at this point in the history

  4. modified isStringTruthy and added test cases

    @mle225
    mle225 committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    dcd1485 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Refactored truthiness checker function 

    - Renamed to `determineTruthyString`
    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f7dfbc0 View commit details
    Browse the repository at this point in the history

  2. Updated tests for determineTruthyString

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    69dd5f3 View commit details
    Browse the repository at this point in the history

  3. Updated import for determineTruthyString

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f9db6ab View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/422

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f53a6da View commit details
    Browse the repository at this point in the history

  5. Attempt number 1 at _Recent Events_ UI

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    af8c952 View commit details
    Browse the repository at this point in the history

  6. Added ICAL parser integration testing 

    - Generated 10 events from the existing `events.ics` testdata file.
- Created a test that verifies that the ICAL parser parses the code deterministically as expected.
    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    5745f3e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'add/ical-parse-integration-test' into fix/422

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    7dcc301 View commit details
    Browse the repository at this point in the history

  8. Show sample events if in debug mode and no events currently exist

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f5ca7fb View commit details
    Browse the repository at this point in the history

  9. Progress

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    877d807 View commit details
    Browse the repository at this point in the history

  10. Updated sample event data

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    8432b35 View commit details
    Browse the repository at this point in the history

  11. This commit should fail the tests, but it won't

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f6f85d1 View commit details
    Browse the repository at this point in the history

  12. Resolved <#455 (comment)> and <#455 (comment)>

    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    ec895ff View commit details
    Browse the repository at this point in the history

  13. Revert "Attempt number 1 at _Recent Events_ UI" 

    This reverts commit af8c952.
    @EthanThatOneKid
    EthanThatOneKid committed May 19, 2022
    Configuration menu
    Copy the full SHA
    a81e7f1 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Renamed determineTruthyString to parseBool

    @EthanThatOneKid
    EthanThatOneKid committed May 20, 2022
    Configuration menu
    Copy the full SHA
    622e488 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/422

    @EthanThatOneKid
    EthanThatOneKid committed May 20, 2022
    Configuration menu
    Copy the full SHA
    76602ae View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. Revert "This commit should fail the tests, but it won't" 

    This reverts commit f6f85d1.
    @EthanThatOneKid
    EthanThatOneKid committed May 21, 2022
    Configuration menu
    Copy the full SHA
    2d0df3d View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Included a case for "any non-falsy string" since any string passed to… 

    … parseBool that isn't falsy should return true.

Resolves <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r879979282>.
    @EthanThatOneKid
    EthanThatOneKid committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7b88b6b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/422

    @EthanThatOneKid
    EthanThatOneKid committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    88e7702 View commit details
    Browse the repository at this point in the history

  3. Refactored parseBool function 

    Resolved <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r878605080>.

Resolved <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r878605142>.
    @EthanThatOneKid
    EthanThatOneKid committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    9e8decb View commit details
    Browse the repository at this point in the history

  4. This is true progress.

    @EthanThatOneKid
    EthanThatOneKid committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4d40cb7 View commit details
    Browse the repository at this point in the history