Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle tags and rearrange author and read time #492

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Restyle tags and rearrange author and read time #492

merged 3 commits into from
Jun 6, 2022

Conversation

jaasonw
Copy link
Contributor

@jaasonw jaasonw commented Jun 4, 2022 •
edited
Loading

image

Resolves
image

@vercel
Copy link

vercel bot commented Jun 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Jun 6, 2022 at 1:07AM (UTC)

@jaasonw jaasonw mentioned this pull request Jun 4, 2022
Merged
@jaasonw jaasonw force-pushed the redesign-blog-tags branch 2 times, most recently from a1e8448 to e1c79f6 Compare June 4, 2022 08:23
@vercel vercel bot temporarily deployed to Preview June 4, 2022 08:23 Inactive
@vercel vercel bot temporarily deployed to Preview June 4, 2022 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview June 4, 2022 09:25 Inactive
@vercel vercel bot temporarily deployed to Preview June 4, 2022 09:30 Inactive
@anhduy1202
Copy link
Collaborator

Hmm, the hashtag position above author seems unusual to me, what do yall think about this design?

image

@vercel vercel bot temporarily deployed to Preview June 5, 2022 03:47 Inactive
@jaasonw jaasonw changed the title Split tags off into their own component, move tags to above author, restyle tags Restyle tags and rearrange author and read time Jun 5, 2022
@vercel vercel bot temporarily deployed to Preview June 5, 2022 05:27 Inactive
@jaasonw jaasonw enabled auto-merge (squash) June 5, 2022 05:29
@jaasonw jaasonw disabled auto-merge June 5, 2022 05:29
anhduy1202
anhduy1202 approved these changes Jun 5, 2022
View reviewed changes
Copy link
Collaborator

@anhduy1202 anhduy1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vercel vercel bot temporarily deployed to Preview June 6, 2022 01:07 Inactive
@jaasonw jaasonw merged commit 66fb72c into main Jun 6, 2022
@jaasonw jaasonw deleted the redesign-blog-tags branch June 6, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhduy1202 anhduy1202 anhduy1202 approved these changes

@charliettaylor charliettaylor Awaiting requested review from charliettaylor

@karnikaavelumani karnikaavelumani Awaiting requested review from karnikaavelumani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaasonw @anhduy1202