Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Git [Link to Download] - Getting_Started.md #652

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Conversation

erwinmedina
Copy link
Contributor

Added a new item [line 4] to the getting started list within the Getting_Started.md file. I added Item2: Installing Git [Link to Git/Downloads]. I also adjusted the numbers listed after that so it would read [1,2,3,4,5,6,7] instead of [1,2,2,3,4,5,6].
Link Issue: Issue #584

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 4:39PM (UTC)

Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Erwin for taking a look at this! There are a couple things that you can edit to make this PR even better in fact. An interesting thing about markdown is its ability to create ordered lists without having a numerical ascending, descending or random order.
image

What this means is that instead of labeling all of the steps as:

1. 
2. 
3. 

We would rather change it so that every single number in the list will begin with just 1 since numbers are automatically rendered no matter the order used in the markdown:

1. 
1. 
1. 

Leaving them all as '1' would make it so that future updates to this list are as simple as appending a new line to the list instead of having to edit all the numbers individually.

If you would like more elaboration, feel free to take a look at this: https://www.markdownguide.org/basic-syntax/#ordered-lists
Basic Syntax | Markdown Guide

@vercel vercel bot temporarily deployed to Preview October 31, 2022 16:31 Inactive
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the help Erwin! Looks good to me:)

@erwinmedina erwinmedina enabled auto-merge (squash) October 31, 2022 16:38
@vercel vercel bot temporarily deployed to Preview October 31, 2022 16:39 Inactive
@erwinmedina erwinmedina merged commit 2bb356c into main Oct 31, 2022
@EthanThatOneKid EthanThatOneKid linked an issue Nov 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide download link for Git
2 participants