Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vercel Audiences #657

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Remove Vercel Audiences #657

merged 2 commits into from
Nov 1, 2022

Conversation

EthanThatOneKid
Copy link
Owner

Why?

  1. Our previous Analytics were failing when in conjunction with the Audiences implementation.
  2. There are no specific examples or instructions on implementing Vercel Audiences in a SvelteKit application.
  3. One problem seems to be the mystery of the /va/script.js because I do not know where that is on the Internet, yet it seems to be required by @vercel/analytics despite finding zero documentation on the subject.

No analytics

Future work

Perhaps I am missing something small, but I know that I must revert the Audiences changes in order to bring back our Vercel Analytics and metrics. When new information is released by Vercel, it might be worth it to try reimplementing Vercel Audiences.

@EthanThatOneKid EthanThatOneKid added the bugfix A PR that fixes a bug label Oct 31, 2022
@EthanThatOneKid EthanThatOneKid self-assigned this Oct 31, 2022
@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 11:02PM (UTC)

@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) November 1, 2022 03:33
@karnikaavelumani
Copy link
Collaborator

lgtm!

@EthanThatOneKid EthanThatOneKid merged commit 79fa887 into main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants