Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json hotfix #705

Merged
merged 3 commits into from
Nov 12, 2022
Merged

package-lock.json hotfix #705

merged 3 commits into from
Nov 12, 2022

Conversation

EthanThatOneKid
Copy link
Owner

Problem

The package-lock.json has been consistently making diffs after contributors npm i on their local branch.

Solution

I deleted the package-lock.json and ran npm i to generate a clean one. I ran the existing tests which seem to pass under the new package-lock.json file.

@EthanThatOneKid EthanThatOneKid added developer experience Enhancement geared towards the devs bugfix A PR that fixes a bug labels Nov 12, 2022
@vercel
Copy link

vercel bot commented Nov 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ❌ Failed (Inspect) Nov 12, 2022 at 8:44AM (UTC)

@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for acmcsuf failed.

Name Link
🔨 Latest commit f21c6a2
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/636f5ce723468f000967fe5f

@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) November 12, 2022 08:44
@vercel vercel bot temporarily deployed to Preview November 12, 2022 08:44 Inactive
Copy link
Contributor

@charliettaylor charliettaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EthanThatOneKid EthanThatOneKid merged commit 88a159b into main Nov 12, 2022
jaasonw added a commit that referenced this pull request Nov 13, 2022
jaasonw added a commit that referenced this pull request Nov 13, 2022
@jaasonw jaasonw deleted the fix/incorrect-deps branch December 27, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug developer experience Enhancement geared towards the devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants