Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirected 404 Button to stay on the original tab. #730

Merged
merged 3 commits into from
Nov 20, 2022

Conversation

DavidJSolano
Copy link
Collaborator

@DavidJSolano DavidJSolano commented Nov 20, 2022

First bug squashed. This PR fixes issue #719

@netlify
Copy link

netlify bot commented Nov 20, 2022

👷 Deploy request for acmcsuf pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 09b9199

@DavidJSolano DavidJSolano added the bugfix A PR that fixes a bug label Nov 20, 2022
src/routes/+error.svelte Outdated Show resolved Hide resolved
DavidJSolano and others added 2 commits November 19, 2022 19:35
Changed prop behavior so that redirect is automatically set to false.
Copy link
Contributor

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the changes specifically i like it as is. personally i think it's kinda weird the button text is <Button text="asdf"> and not <Button>asdf</Button> tho but thats out of the scope of this pr

@DavidJSolano DavidJSolano merged commit d2bc84a into EthanThatOneKid:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants