Changed all label formats to match the original. #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes issue#655.
👷 Deploy request for acmcsuf pending review.Visit the deploys page to approve it
|
Updated the label to contain the rel "noopener noreferrer".
EthanThatOneKid
approved these changes
Nov 30, 2022
jaasonw
suggested changes
Nov 30, 2022
All label colors were replaced with var(--acm-...)
|
|
EthanThatOneKid
approved these changes
Dec 7, 2022
jaasonw
suggested changes
Dec 7, 2022
Changed the color of the labels in labelfield.svelte to match acm colors.
|
Alright, I duplicated these changes to the labels in labelfield.svelte. I think it's fair to mention that the selected labels have an altered look when changed to strictly ACM colors, not sure how you guys feel about this look. Should I revert it back to the original colors? |
Thanks for following up, @DavidJSolano! I think we should go back to the original colors. |
I removed the ACM colors from the .selected labels and reverted them to the original blue look.
Changed labelfield.svelte color to be var(--acm--dark) to be compatible with dark/light mode.
|
Okay, this is what the final product looks like after reverting the selected labels to their original colors and making them compatible with light/dark mode. |
jaasonw
suggested changes
Dec 14, 2022
Tiny syntactical error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #655. The new labels look like this:
