Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new page for board applications #754

Merged
merged 13 commits into from
Jan 20, 2023
Merged

Create new page for board applications #754

merged 13 commits into from
Jan 20, 2023

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Jan 18, 2023

/s23positions

This PR creates a new page for board applications, as per the request in #750. The page can be found at https://acmcsuf.com/s23positions.

The form for students to apply can be accessed via the following link: https://acmcsuf.com/s23apply

The button on the page links to the form for students to apply.

The content for the page, including information about each application, has been copied and pasted from the following Google Doc: https://docs.google.com/document/d/1jTtr2UUEJsRsz0AOQPTe_f0lDk89BK_tfiw590o_U_s/edit#heading=h.yqghk8npo2et

The page design can be viewed at the following Figma link: https://www.figma.com/file/25dCY91gyAqADj3aB9xgfl/Board-Apps?node-id=0%3A1&t=WA866jRB4hQrFrrN-0

Changelog

  • New page endpoint /s23positions
  • Add "Marketing Officer", "Game Dev Leader", and "Game Dev Officer" to src/lib/public/board/data/tiers.json
  • Add --acm-foundry-rgb, --acm-marketing-rgb, and .brand-italic to static/global.css

Resolves #750

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit bef4368
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/63ca1d54b12cfe0008431b00
😎 Deploy Preview https://deploy-preview-754--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/lib/public/board/data/index.ts Outdated Show resolved Hide resolved
src/lib/public/board/data/officers.json Outdated Show resolved Hide resolved
src/routes/(site)/s23positions/+page.svelte Outdated Show resolved Hide resolved
src/routes/(site)/s23positions/data.ts Show resolved Hide resolved
src/routes/(site)/s23positions/position-list.svelte Outdated Show resolved Hide resolved
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review January 18, 2023 17:48
@jaasonw
Copy link
Contributor

jaasonw commented Jan 18, 2023

image

on safari

apply link doesnt work

image

headers are inconsistent

@EthanThatOneKid
Copy link
Owner Author

headers are inconsistent

We honestly don’t need the second header.

@EthanThatOneKid
Copy link
Owner Author

on safari

I just noticed this on my iPhone! Thanks for sharing the screenshot.

@EthanThatOneKid
Copy link
Owner Author

apply link doesnt work

Oops; I intend to double check this.

@jaasonw
Copy link
Contributor

jaasonw commented Jan 18, 2023

We honestly don’t need the second header.

3rd header same issue

@EthanThatOneKid
Copy link
Owner Author

apply link doesnt work

This is unusual. I can confirm it does not work as well as any other local additions to src/lib/server/links/data.ts.

@karnikaavelumani
Copy link
Collaborator

Looks amazing! Thank you so much for bringing my figma design to reality and also making it even better!

Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@EthanThatOneKid
Copy link
Owner Author

Looks amazing! Thank you so much for bringing my figma design to reality and also making it even better!

Thank you for the kind words! :godmode:

@EthanThatOneKid
Copy link
Owner Author

EthanThatOneKid commented Jan 19, 2023

Screenshots

Taken from a2ec585.

Collapsed

image

Expanded

image

image

image

image

image

@jaasonw
Copy link
Contributor

jaasonw commented Jan 19, 2023

why left justified headings when all other headings on the site are centered?

@EthanThatOneKid
Copy link
Owner Author

EthanThatOneKid commented Jan 19, 2023

why left justified headings when all other headings on the site are centered?

Though this does not follow best practices, there are various examples in acmcsuf.com v4.0, such as /privacy. I perceive this time as an opportunity to try something new before the big, official redesign.

In short, yes you’re right, but as this is a one-off page I am saving that level of consistency for the upcoming redesign.

Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the apply button now works on both desktop and mobile (safari). I don't mind the opening and ending content to be aligned to the left. This page can definitely be improved on for future uses but I do need this page ASAP so thank you so much for creating it!

@EthanThatOneKid EthanThatOneKid merged commit 6a3f74f into main Jan 20, 2023
EthanThatOneKid added a commit that referenced this pull request Jan 20, 2023
Create new page for board applications (#754)
@jaasonw jaasonw deleted the fix/750 branch February 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create acmcsuf.com/s23positions
3 participants