Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unique TextAlignment enum #774

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Make unique TextAlignment enum #774

merged 1 commit into from
Feb 17, 2023

Conversation

EthanThatOneKid
Copy link
Owner

Removes a duplicate enum TextAlignment, asserting that the only instance of a TextAlignment enum in this repository is the one defined in src/lib/public/text-alignment/text-alignment.ts.

Resolves #582.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit c535b2f
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/63efe7adc2d960000848e4fe
😎 Deploy Preview https://deploy-preview-774--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@EthanThatOneKid EthanThatOneKid changed the title Make src/lib/public/text-alignment/text-alignment.ts unique Make unique TextAlignment enum Feb 17, 2023
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review February 17, 2023 20:47
@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) February 17, 2023 20:47
Copy link
Contributor

@charliettaylor charliettaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes very nice epic and cool :) don't you ever make it not unique again
funny gif very nice

@EthanThatOneKid EthanThatOneKid merged commit 5402167 into main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy TextAlignment is a duplicate of src/lib/public/text-alignment/text-alignment.ts
2 participants