Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix title behind navbar #815

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Fix title behind navbar #815

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e12b7fa
Fix title behind navbar
nghuyhoang0204 Mar 15, 2023
1156c27
Update changes requested for this issue
nghuyhoang0204 Mar 19, 2023
49f612e
Commit again
nghuyhoang0204 Mar 20, 2023
f1cb7fb
Undo these changes aren't in the scope of this Pr
nghuyhoang0204 Mar 20, 2023
af5cc8f
Changes requested done
nghuyhoang0204 Mar 21, 2023
8e56ce6
Merge branch 'main' into fix/title-navbar
EthanThatOneKid Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/components/button/button.svelte
View file
Open in desktop
EthanThatOneKid marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
user-select: none;
transition: 0.25s ease-in-out;


EthanThatOneKid marked this conversation as resolved.
Show resolved Hide resolved
&:hover {
background-color: var(--button-hover);
}
Expand Down
31 changes: 14 additions & 17 deletions src/routes/+error.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,37 +12,34 @@
</svelte:head>

<section title={$page.error?.message}>
<em>404</em>
<h1>Frank can't find where you're going!</h1>
<Button text={'Return to Home'} link={'/'} />
<img src="/assets/png/lost-frank.png" alt="404 - Page Not Found" />
<div class="container">
<div>
<em>404</em>
<h1>Frank can't find where you're going!</h1>
<Button text={'Return to Home'} link={'/'} />
</div>
<img src="/assets/png/lost-frank.png" alt="404 - Page Not Found" />
</div>
</section>

<Footer />

<style>
section {
.container {
min-height: 100vh;
display: flex;
gap: 2rem;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
margin: 0 24px;
color: var(--acm-light);
}

section h1 {
align-items: center;
height: 120vh;
EthanThatOneKid marked this conversation as resolved.
Show resolved Hide resolved
text-align: center;
}

section em {
align-items: center;
text-align: center;
font-size: 50px;
text-shadow: 2px 2px #92c4df;
font-weight: 600;
em {
font-size: 40px;
text-shadow: rgb(146, 196, 223) 2px 2px;
EthanThatOneKid marked this conversation as resolved.
Show resolved Hide resolved
}

section img {
Expand Down