Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate links data file #816

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Delete duplicate links data file #816

merged 3 commits into from
Mar 20, 2023

Conversation

karnikaavelumani
Copy link
Collaborator

Fix #756.

@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 42023b1
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/6418df6447ee250008ace519
😎 Deploy Preview https://deploy-preview-816--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍛🍣🐖😶🍕♑🈹🐒🐆🦬🍕🍔🍟😮🍟🥨🥡🍤🥩🚞🍕🚃😭🧐🥙🍕🍔🚠🚆🛹🚋🚈🛴💫💨💝💌🕳️🚋🍕🥨🚡💦💕🥺🤔🐕🐎💞🏍️🏎️🍕💫😌🍕🤑💫💢💗☯️♌⛎😥😢♍😧😨🤨👉👈🈹

@karnikaavelumani
Copy link
Collaborator Author

#756 (comment)

@jaasonw can you take a look at this? For some reason the student-pack shortlink, which is supposed to link to https://acmcsuf.com/blog/806 link, is the only one that does not work. Do you know why?

@jaasonw
Copy link
Contributor

jaasonw commented Mar 20, 2023

is it not bcus they're duplicated?

@EthanThatOneKid
Copy link
Owner

EthanThatOneKid commented Mar 20, 2023

is it not bcus they're duplicated?

No. We discovered a regression in the findURL function.

The current plan is to replace the code path that throws by passing a destinationOrigin to use when resolving a found shortlink missing a destination origin.

However, this means findURL finds a URL every time which strays from the expected behavior implied by the function name.

@EthanThatOneKid
Copy link
Owner

No. We discovered a regression in the findURL function.

The findURL regression has been followed up in #818.

@jaasonw
Copy link
Contributor

jaasonw commented Mar 20, 2023

https://docs.netlify.com/routing/redirects/ why not just do all these redirects directly in netlify

@EthanThatOneKid
Copy link
Owner

https://docs.netlify.com/routing/redirects/ why not just do all these redirects directly in netlify

We want the feature to work no matter which provider we deploy with.

@karnikaavelumani karnikaavelumani merged commit 4f95756 into main Mar 20, 2023
@karnikaavelumani karnikaavelumani deleted the fix/756 branch March 20, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate links data file
3 participants