Migration to Svelte 4 #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `npx svelte-migrate@latest svelte-4` See: <https://svelte.dev/docs/v4-migration-guide>.
Run `npx svelte-migrate@latest svelte-4` See: <https://svelte.dev/docs/v4-migration-guide>.
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TODO: Consolidate old config files with new config files.
``` 26:48 error '_' is defined but never used @typescript-eslint/no-unused-vars ```
32:3 error A11y: <div> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile
Resolved error messages: ``` C:\Users\ethan\Documents\GitHub\acmcsuf.com\src\lib\components\select\select.svelte 22:5 error A11y: <div> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile 29:11 error A11y: <div> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile ```
…d mouse or keyboard event listeners C:\Users\ethan\Documents\GitHub\acmcsuf.com\src\routes\(site)\events\event.svelte 39:3 error A11y: Non-interactive element <details> should not be assigned mouse or keyboard event listeners.(a11y-no-noninteractive-element-interactions) svelte/valid-compile
``` error Unused CSS selector ".container li details summary[open]"(css-unused-selector) svelte/valid-compile ```
135:9 error Unused CSS selector "section ul li a > h2"(css-unused-selector) svelte/valid-compile
```
231:5 error Unused CSS selector ".event-actionbar"(css-unused-selector)
svelte/valid-compile
```
``` 121:3 error Unused CSS selector ".grid-inner-wrapper .wide"(css-unused-selector) svelte/valid-compile 125:3 error Unused CSS selector ".grid-inner-wrapper .tall"(css-unused-selector) svelte/valid-compile 129:3 error Unused CSS selector ".grid-inner-wrapper .big"(css-unused-selector) svelte/valid-compile ```
``` 13:1 error A11y: <span> with click, keydown handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile 19:3 error A11y: <span> with click, keydown handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile ```
```
C:\Users\ethan\Documents\GitHub\acmcsuf.com\src\routes\(site)\wave1\+page.svelte
86:5 error A11y: <span> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile
93:3 error A11y: <div> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile
140:3 error Unused CSS selector ".page-body"(css-unused-selector)
svelte/valid-compile
C:\Users\ethan\Documents\GitHub\acmcsuf.com\src\routes\(site)\wave2\+page.svelte
86:5 error A11y: <span> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile
93:3 error A11y: <div> with click, keypress handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile
140:3 error Unused CSS selector ".page-body"(css-unused-selector)
svelte/valid-compile
```
``` 143:7 error A11y: <div> with click, keydown handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile 159:9 error A11y: <div> with click, keydown handlers must have an ARIA role(a11y-no-static-element-interactions) svelte/valid-compile ```
```
52:3 error Unused CSS selector "section.collage-container"(css-unused-selector)
svelte/valid-compile
60:5 error Unused CSS selector "section.collage-container .collage-container-inner"(css-unused-selector) svelte/valid-compile
```
``` Error: Property 'timeZone' does not exist on type 'ZonedDateTime'. Did you mean 'timeZoneId'? const dtStart = zonedDateTimeFromGCalDateTime(new Date(event.start.dateTime), refDate.timeZone); const dtEnd = zonedDateTimeFromGCalDateTime(new Date(event.end.dateTime), refDate.timeZone); const date = dtStart.toString(); ==================================== svelte-check found 2 errors and 0 warnings in 1 file ```
karnikaavelumani
approved these changes
Jul 31, 2023
EthanThatOneKid
force-pushed
the
fix/882
branch
from
71ae30f
to
b7bbbca
Compare
Closed
EthanThatOneKid
added a commit
that referenced
this pull request
Oct 4, 2023
Resolves <#884 (review)>. ### Technique run `for /r %a in ("page.test.ts") do del "%a"`.
EthanThatOneKid
added a commit
that referenced
this pull request
Oct 4, 2023
* Update check_website.yaml * Drop `@playwright/test` tool Resolves <#884 (review)>. ### Technique run `for /r %a in ("page.test.ts") do del "%a"`.
EthanThatOneKid
added a commit
that referenced
this pull request
Oct 4, 2023
* Update check_website.yaml * Drop `@playwright/test` tool Resolves <#884 (review)>. ### Technique run `for /r %a in ("page.test.ts") do del "%a"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://svelte.dev/docs/v4-migration-guide.
Resolves #882.