Introduce New Types For Subscription Positions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
9 times, most recently
from
e01ee93
to
be69669
Compare
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
from
be69669
to
4c21e46
Compare
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
from
4c21e46
to
7c16de9
Compare
oskardudycz
reviewed
Feb 2, 2022
oskardudycz
reviewed
Feb 2, 2022
oskardudycz
reviewed
Feb 2, 2022
hayley-jean
reviewed
Feb 2, 2022
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
2 times, most recently
from
fc6a829
to
91e2e7f
Compare
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
from
91e2e7f
to
b860e77
Compare
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
from
b860e77
to
04ad5e0
Compare
oskardudycz
previously approved these changes
Feb 3, 2022
hayley-jean
previously approved these changes
Feb 3, 2022
timothycoleman
requested changes
Feb 3, 2022
thefringeninja
dismissed stale reviews from hayley-jean and oskardudycz
via
93ff2dd
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
2 times, most recently
from
93ff2dd
to
2273a1e
Compare
thefringeninja
requested review from
timothycoleman,
oskardudycz and
hayley-jean
thefringeninja
force-pushed
the
like-subscribe-bell-button
branch
from
2273a1e
to
010f3ee
Compare
hayley-jean
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: New Types for Subscription Positions
Having an if statement to call one of two overloads when trying to subscribe has proved cumbersome. Adding two new types,
FromAllandFromStream, should make it easier for consumers.Fixes: #186