Support infinite timeouts #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
approved these changes
Jun 2, 2020
pgermishuys
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Hey @shaan1337, good work!
For the 2nd part,
- We could potentially split the
TimeoutAfteron theEventStoreClientOperationOptionsinto 2 namelyReadTimeoutAfterandAppendTimeoutAfterand default the read toTimeSpan.MaxValueandAppendTimeoutAfterto 5 seconds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes: #29
This PR allows infinite operation timeouts by specifying TimeSpan.MaxValue or Timeout.InfiniteTimeSpan in EventStoreClientOperationOptions.TimeoutAfter.
The second part of the issue (default timeout) has not been dealt with yet. The issue is that just changing the default timeout from 5 seconds to infinity would affect the default timeouts of all operations, not only stream read operations: https://github.com/EventStore/EventStore-Client-Dotnet/blob/master/src/EventStore.Client/EventStoreClientOperationOptions.cs#L10
We could override them in these specific stream read operations but i'm not sure if there's a better approach.