Fix check for parent context when extract propagation context fails #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
changed the title
w1am
force-pushed
the
DEVEX-75-NET-Client-Exception-on-non-json-metadata-events
branch
from
f55461a
to
62915aa
Compare
w1am
force-pushed
the
DEVEX-75-NET-Client-Exception-on-non-json-metadata-events
branch
from
62915aa
to
1ff5d29
Compare
w1am
requested review from
YoEight and
RagingKore
and removed request for
YoEight and
RagingKore
w1am
deleted the
DEVEX-75-NET-Client-Exception-on-non-json-metadata-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Removed check for "application/json" when tracing subscriptions
Changed: Try to inject trace context in metadata regardless of event type.
Changed: Extract trace context from Event rather than OriginalEvent to account for link metadata.
Fixed: Fix check for parent context when extract propagation context fails
Previously,
if (parentContext == null) return;was returning false even though the extraction of the propagation context had failed. I changed it toparentContext == default(ActivityContext)because the tracing method returns a defaultActivityContextwhen it fails to extract the trace context.