Merge pull request #23815 from rezkiy37/fix/21456-pass-write-capability

Fix/21456 - Polish admins-only policy room - Pass arguments properly
Expensify · Jul 31, 2023 · 024d210 · 024d210
2 parents eb02006 + cdd844b
commit 024d210
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/components/ReportActionItem/MoneyRequestAction.js b/src/components/ReportActionItem/MoneyRequestAction.js
@@ -110,6 +110,7 @@ function MoneyRequestAction(props) {
                 false,
                 '',
                 undefined,
+                undefined,
                 CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
                 props.action.reportActionID,
                 props.requestReportID,

diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js
@@ -1876,7 +1876,7 @@ function buildOptimisticChatReport(
     isOwnPolicyExpenseChat = false,
     oldPolicyName = '',
     visibility = undefined,
-    writeCapability = CONST.REPORT.WRITE_CAPABILITIES.ALL,
+    writeCapability = undefined,
     notificationPreference = CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
     parentReportActionID = '',
     parentReportID = '',
@@ -2046,6 +2046,7 @@ function buildOptimisticWorkspaceChats(policyID, policyName) {
         false,
         policyName,
         null,
+        undefined,
 
         // #announce contains all policy members so notifying always should be opt-in only.
         CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

diff --git a/src/libs/actions/Report.js b/src/libs/actions/Report.js
@@ -587,6 +587,7 @@ function navigateToAndOpenChildReport(childReportID = '0', parentReportAction =
             false,
             '',
             undefined,
+            undefined,
             CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
             parentReportAction.reportActionID,
             parentReportID,
@@ -1270,7 +1271,7 @@ function navigateToConciergeChat() {
  * @param {Array<Number>} policyMembersAccountIDs
  * @param {String} writeCapability
  */
-function addPolicyReport(policyID, reportName, visibility, policyMembersAccountIDs, writeCapability) {
+function addPolicyReport(policyID, reportName, visibility, policyMembersAccountIDs, writeCapability = CONST.REPORT.WRITE_CAPABILITIES.ALL) {
     // The participants include the current user (admin), and for restricted rooms, the policy members. Participants must not be empty.
     const members = visibility === CONST.REPORT.VISIBILITY.RESTRICTED ? policyMembersAccountIDs : [];
     const participants = _.unique([currentUserAccountID, ...members]);