Merge pull request #24254 from dantastisk/fix/23137

fix: 23137 Slow animation on sign in input
Expensify · Aug 10, 2023 · 27b12b9 · 27b12b9
2 parents e8540aa + 81f6dd6
commit 27b12b9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/pages/signin/SignInPageLayout/BackgroundImage/index.js b/src/pages/signin/SignInPageLayout/BackgroundImage/index.js
@@ -2,29 +2,29 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import MobileBackgroundImage from '../../../../../assets/images/home-background--mobile.svg';
 import DesktopBackgroundImage from '../../../../../assets/images/home-background--desktop.svg';
+import styles from '../../../../styles/styles';
 
 const defaultProps = {
     isSmallScreen: false,
-    style: [],
 };
 
 const propTypes = {
     isSmallScreen: PropTypes.bool,
     pointerEvents: PropTypes.string.isRequired,
     width: PropTypes.number.isRequired,
-    style: PropTypes.oneOfType([PropTypes.object, PropTypes.arrayOf(PropTypes.object)]),
 };
 function BackgroundImage(props) {
     return props.isSmallScreen ? (
         <MobileBackgroundImage
             pointerEvents={props.pointerEvents}
             width={props.width}
-            style={props.style}
+            style={styles.signInBackground}
         />
     ) : (
         <DesktopBackgroundImage
             pointerEvents={props.pointerEvents}
             width={props.width}
+            style={styles.signInBackground}
         />
     );
 }

diff --git a/src/pages/signin/SignInPageLayout/index.js b/src/pages/signin/SignInPageLayout/index.js
@@ -126,7 +126,6 @@ function SignInPageLayout(props) {
                             isSmallScreen
                             pointerEvents="none"
                             width={variables.signInHeroBackgroundWidthMobile}
-                            style={styles.signInBackgroundMobile}
                         />
                         <SignInPageContent
                             welcomeHeader={props.welcomeHeader}

diff --git a/src/styles/styles.js b/src/styles/styles.js
@@ -1194,14 +1194,7 @@ const styles = {
         left: 0,
     },
 
-    signInBackgroundDesktop: {
-        position: 'absolute',
-        bottom: 0,
-        left: 0,
-        minHeight: 700,
-    },
-
-    signInBackgroundMobile: {
+    signInBackground: {
         position: 'absolute',
         bottom: 0,
         left: 0,