Only pass numberic strings to Str.fromUSDToNumber

Str.fromUSDToNumber now crashes if you pass a boolean true|false or strings that are not valid numbers
Expensify · Aug 22, 2023 · b955641 · b955641
1 parent 06f34c6
commit b955641
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/pages/ReimbursementAccount/ValidationStep.js b/src/pages/ReimbursementAccount/ValidationStep.js
@@ -67,7 +67,7 @@ class ValidationStep extends React.Component {
         const errors = {};
 
         _.each(values, (value, key) => {
-            const filteredValue = this.filterInput(value);
+            const filteredValue = typeof value === 'string' ? this.filterInput(value) : value;
             if (ValidationUtils.isRequiredFulfilled(filteredValue)) {
                 return;
             }
@@ -103,7 +103,7 @@ class ValidationStep extends React.Component {
      */
     filterInput(amount) {
         let value = amount ? amount.toString().trim() : '';
-        if (value === '' || !Math.abs(Str.fromUSDToNumber(value)) || _.isNaN(Number(value))) {
+        if (value === '' || _.isNaN(Number(value)) || !Math.abs(Str.fromUSDToNumber(value))) {
             return '';
         }