Merge pull request #46930 from Expensify/jack-preventOpenWorkspacewith-1

Prevent calling OpenWorkspace with an empty policyID
Expensify · Aug 7, 2024 · de89479 · de89479
2 parents 8c11aa4 + b3451be
commit de89479
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/pages/home/sidebar/SidebarLinksData.tsx b/src/pages/home/sidebar/SidebarLinksData.tsx
@@ -39,8 +39,14 @@ function SidebarLinksData({insets, isLoadingApp = true, onLinkClick, priorityMod
 
     const {orderedReportIDs, currentReportID, policyMemberAccountIDs} = useReportIDs();
 
-    // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
-    useEffect(() => Policy.openWorkspace(activeWorkspaceID ?? '-1', policyMemberAccountIDs), [activeWorkspaceID]);
+    useEffect(() => {
+        if (!activeWorkspaceID) {
+            return;
+        }
+
+        Policy.openWorkspace(activeWorkspaceID, policyMemberAccountIDs);
+        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
+    }, [activeWorkspaceID]);
 
     const isLoading = isLoadingApp;
     const currentReportIDRef = useRef(currentReportID);