Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$4000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia #11089

Closed
mvtglobally opened this issue Sep 19, 2022 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Go to settings > security > change password

Expected Result:

The keyboard should open

Actual Result:

The keyboard doesn't open

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Mobile Web iPad (safari)

Version Number: 1.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1661701238.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661709051676959

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 19, 2022
@sonialiap
Copy link
Contributor

I can replicate the behavior 👍

@sonialiap sonialiap removed their assignment Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MariaHCD MariaHCD added the External Added to denote the issue can be worked on by a contributor label Sep 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 20, 2022
@MariaHCD MariaHCD removed their assignment Sep 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2022

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [$250] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Sep 20, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Sep 20, 2022
@melvin-bot

This comment was marked as off-topic.

@MariaHCD MariaHCD added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 20, 2022
@JmillsExpensify
Copy link

Also replicated the behavior. It's reproducible on Safari across all iOS platforms. I've created a job in Upwork here: https://www.upwork.com/jobs/~01f0a06e71a7da3f54. We're open for proposals!

@rushatgabhane
Copy link
Member

@JmillsExpensify Before closing, I think we should wait until Applause can't reproduce the bug in their weekly tests.

(hold on doubling because i can't repro it either)

@jeet-dhandha
Copy link
Contributor

Tested this not Reproducible.

@thesahindia
Copy link
Member

It's still reproducible for me.

@JmillsExpensify
Copy link

Woah, yes, I can reproduce this now. That said, I think this is a symptom of our larger keyboard issue and should be put on hold while we work through that initiative first. Tracking issue is here. Sound good?

@JmillsExpensify JmillsExpensify changed the title [$500] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [Hold #10273] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Oct 5, 2022
@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 5, 2022

#10273 is related to KeyboardAvoidingView, as in how much the content should move up when the virtual keyboard is opened.

This issue is about the keyboard not opening, so I think we should remove the hold. Thoughts?

cc @JmillsExpensify

@JmillsExpensify
Copy link

That's a good point. I was specifically thinking of this mention in the problem statement.

For example, we have some screens where we use timeouts to wait for navigation transitions to finish before opening the keyboard

But I think you're right, being sluggish and opening slowly is different than not opening (on Ipad mWeb) at all.

@melvin-bot

This comment was marked as off-topic.

@JmillsExpensify JmillsExpensify changed the title [Hold #10273] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Oct 6, 2022
@JmillsExpensify
Copy link

We're open for proposals again!

@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 6, 2022

For example, we have some screens where we use timeouts to wait for navigation transitions to finish before opening the keyboard

Ohhh, I didn't know that and I see where you're coming from now.

You might be right about holding this issue because a fix might involve using timeouts.
Let's figure it out by looking at some proposals?

@JmillsExpensify JmillsExpensify changed the title iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [$250] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Oct 10, 2022
@JmillsExpensify
Copy link

Ah yes, all good! I like the idea of trying to verify one way or another via proposals.

@JmillsExpensify
Copy link

Doubling the price in the hopes of getting more proposals.

@JmillsExpensify JmillsExpensify changed the title [$250] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [$500] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Oct 14, 2022
@JmillsExpensify JmillsExpensify changed the title [$500] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [$1000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Oct 14, 2022
@JmillsExpensify
Copy link

Still waiting on proposals. I will circle back in the coming days to double the price if we still don't get proposals.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2022
@JmillsExpensify
Copy link

Alrighty, doubling the price. When we get proposals, we'll be able to more accurately understand if this is related to the linked, and larger, keyboard initiative above.

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2022
@JmillsExpensify JmillsExpensify changed the title [$1000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [$2000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Oct 26, 2022
@rushatgabhane
Copy link
Member

The proposal should be wholistic and fix the issue for all the following pages

  • secondary login
  • add paypal
  • workspace new room
  • change password
  • new chat
  • new group

@JmillsExpensify
Copy link

Alright, doubling the price again. We still lack proposals.

@JmillsExpensify JmillsExpensify changed the title [$2000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia [$4000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia Nov 1, 2022
@sketchydroide
Copy link
Contributor

closing as duplicated of #10414 more details here and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants