[HOLD for payment 2022-10-20] [$250] New Room - No focus on New Room composed box after click New Room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with your account
3. Click on Fub menu
4. Click New Room

Expected Result:

There is a focus on New Room composed box after click New Room

Actual Result:

No focus on New Room composed box after click New Room

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.11.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5757836_Screen_Recording_20221001-070735_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Infernal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Puneet-here]

Proposal

Create a function focusRoomNameInput and bind it

focusRoomNameInput() {
        if (!this.newRoomInputRef) {
            return;
        }

        this.newRoomInputRef.focus();
}

Use onTransitionEnd prop in ScreenWrapper and pass focusRoomNameInput

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 144 in 9ff60c3

<ScreenWrapper>

Use ref at RoomNameInput like below

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 151 in 9ff60c3

<RoomNameInput

ref={el => this.newRoomInputRef = el}

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Beamanator]

Looks like a good external issue 👍

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @Beamanator is eligible for the External assigner, not assigning anyone new.

[parasharrajat]

Click on Fub menu

FAB.

No one noticed it during triaging. 😱

@Puneet-here 's proposal looking good to me.

cc: @Beamanator

🎀 👀 🎀 C+ reviewed

[Beamanator]

Makes sense to me! Idk how this was missed during triage 🤷

[melvin-bot]

📣 @Puneet-here You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[NicMendonca]

Not overdue, latest PR update here

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Autofocus the room name field #11587

If no regressions arise, payment will be issued on 2022-10-20. 🎊

[aimane-chnaif]

mobile-safari.mov

The solution doesn't work on mobile safari. Room Name field is blue outlined but keyboard is not showing unless user focus manually.

[parasharrajat]

Maybe this is happening due to safari browser versions. What is your version of IOS and safari? and @Puneet-here What is yours?

[aimane-chnaif]

Maybe this is happening due to safari browser versions. What is your version of IOS and safari? and @Puneet-here What is yours?

16.0
The video @Puneet-here attached in PR is when Connect Hardware Keyboard enabled in simulator, so not able to reproduce.
I think we need to apply this to all PRs unless testing with physical device (maybe update description in PR template)

[parasharrajat]

Let me test it.

[Puneet-here]

It's working for me. I am on ios 16.0

[aimane-chnaif]

It's working for me. I am on ios 16.0

It would be good to share working video with keyboard opening on mobile safari

[Puneet-here]

Screen.Recording.2022-10-14.at.5.18.08.PM.mov

[aimane-chnaif]

Hmm, that's strange.
@parasharrajat tests well on your side?

I tested on iPad physical device
demo: https://drive.google.com/file/d/1smxXgpEu6qRBayQrann3l0fIhyml5UBN/view?usp=sharing

[parasharrajat]

Unfortunately, I currently don't own an iPhone(looking to buy a new one soon) and use an emulator.

The focus was working for me on iOS 15 as well(simulator). let me ask someone to test it on their device.

[parasharrajat]

If this proves the differences between simulators and real devices, then I will discuss this internally.

[gadhiyamanan]

not working on ios 16 for me . might be related to this slack conversation

NOTE: keyboard does not open on new chat or new group for me

IMG_0232.mov

[thesahindia]

We have a similar issue for some other pages( #11089 )

[parasharrajat]

Is anyone interested to suggest a solution that works on both real devices and simulators? Then I will be able to analyze this and propose a general process to tackle such issues.

Note: this is a personal request, I do not guarantee any compensation for that.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[NicMendonca]

@Puneet-here @parasharrajat can you please accept the job offer when you get the chance?

[Beamanator]

@parasharrajat are we good to issue payment for this or do you think it needs to be delayed a bit?

[parasharrajat]

We can release the payment. No need to delay.

[NicMendonca]

@parasharrajat @Puneet-here paid, thanks!