Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payment due 30/8][$250] Migrate ThreeDotsMenu/index.js to function component #16209

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 80 comments
Closed
1 task

[Payment due 30/8][$250] Migrate ThreeDotsMenu/index.js to function component #16209

marcaaron opened this issue Mar 20, 2023 · 80 comments
Assignees
@bondydaa @allroundexperts @kadiealexander @adityaaa-r
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc503ac4e0afb293
  • Upwork Job ID: 1685093542058012672
  • Last Price Increase: 2023-07-29
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.js to function component [HOLD][$250] Migrate index.js to function component Apr 13, 2023
@s-alves10
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@marcaaron marcaaron changed the title [HOLD][$250] Migrate index.js to function component [HOLD][$250] Migrate ThreeDotsMenu/index.js to function component Jul 29, 2023
@marcaaron marcaaron changed the title [HOLD][$250] Migrate ThreeDotsMenu/index.js to function component [$250] Migrate ThreeDotsMenu/index.js to function component Jul 29, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01dc503ac4e0afb293

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($250)

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

📣 @adityaaa-r You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@bondydaa
Copy link
Contributor

bondydaa commented Aug 2, 2023

oh sorry! this got hidden on my dashboard b/c of the reviewing label so I didn't realize I was blocking here (just another reason to wait for the PR til you're assigned 😉)

@adityaaa-r
Copy link
Contributor

haha. sure! @bondydaa
I'll wait for the PR till i'm assigned from now on.

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @adityaaa-r got assigned: 2023-08-02 22:31:05 Z
  • when the PR got merged: 2023-08-17 03:29:48 UTC
  • days elapsed: 10

On to the next one 🚀

@nileshahir286
Copy link

Hey,
Can you assign me this stuff?
I can do it today and generate the PR.

Thanks
Nilesh

@adityaaa-r
Copy link
Contributor

@bondydaa hold for payment label not updated here yet.

@adityaaa-r
Copy link
Contributor

@bondydaa please process the payment today, the regression period is over.
cc: @allroundexperts

@bondydaa
Copy link
Contributor

@kadiealexander can you handle getting this paid out #16209 (comment)

@kadiealexander
Copy link
Contributor

@adityaaa-r could you please apply here? I'm not able to find your Upwork profile to send you a contract. Thanks!

@kadiealexander kadiealexander changed the title [$250] Migrate ThreeDotsMenu/index.js to function component [Payment due 30/8][$250] Migrate ThreeDotsMenu/index.js to function component Aug 31, 2023
@sullyAL
Copy link

sullyAL commented Aug 31, 2023

Contributor details
Your Expensify account email: vulajsv@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/sully

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@sullyAL
Copy link

sullyAL commented Aug 31, 2023

Proposal

Convert class names into functional names
Example "class Form extend React.Component" to "function Form"

Check state management and life cycles and carefully undersatnd the component
Thoroughly test the new functional component before submiting the code

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 31, 2023
@kadiealexander
Copy link
Contributor

@sullyAL Thanks for taking the time to put a proposal together for this! Sorry if it wasn't clear, but we are only looking for proposals on issues with the Help Wanted label here. Please take a look at those and feel free to submit a proposal if you think you can fix anything.

@adityaaa-r
Copy link
Contributor

@kadiealexander applied!

@kadiealexander
Copy link
Contributor

Thanks @adityaaa-r! Let me know when you've accepted the contract I sent across.

@adityaaa-r
Copy link
Contributor

offer accepted! @kadiealexander

@heyFahad
Copy link

Contributor details
Your Expensify account email: Fahad_Javed008@yahoo.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01604e3bea5d2959e5

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@pranavmappoli
Copy link

Contributor details
Your Expensify account email: pranavmappoli@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a31facdaca69896a

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@pranavmappoli
Copy link

Contributor details
Your Expensify account email: pranavmappoli@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a31facdaca69896a

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@kadiealexander
Copy link
Contributor

kadiealexander commented Sep 1, 2023 •
edited by JmillsExpensify
Loading

Payouts due:

Eligible for 50% #urgency bonus? No

Upwork job is here.

@kadiealexander
Copy link
Contributor

@allroundexperts are you being paid in Upwork or NewDot?

@JmillsExpensify
Copy link

Reviewed the details for @allroundexperts. $250 payment approved via NewDot based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bondydaa bondydaa

@allroundexperts allroundexperts

@kadiealexander kadiealexander

@adityaaa-r adityaaa-r

Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests