[HOLD for payment 2023-05-22] workspace name doesn't update in the message field if changed from the other platform

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot and login with User A (Platform 1)
2. Go to any workspace (let's say workspace A) > Go to invite members > Select any member > Make sure you are on the message page
3. Login with the same user A on other platform (Platform 2) and change the workspace A name
4. In the platform 1, see that the header of the workspace names updates properly , but the workspace name in the message field doesn't update

Expected Result:

The name of the workspace should update in the message field if changed from the other platform

Actual Result:

The name of the workspace doesn't update in the message field if changed from the other platform

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

name.mp4

Recording.527.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683434527583039

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Seems regression from #15672 where #17559 changes overwritten

[abdulrahuman5196]

PR for fix - #18601

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixing regression from Invite message refractor #18601

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[isabelastisser]

@Pujan92, I need clarification about what I must do here and by your comment.

#18597 (comment)

• I was assigned this issue reported by @avi-shek-jha.
• I still need to reproduce it; no external label was applied. Therefore no C+ was assigned, and no proposal was chosen.

Can you please guide me? Why is the payment triggered? Was this issue specifically to pay for a regression?

Cc @kavimuru since you created this.

@abdulrahuman5196, is the payment for this PR fix?

#18597 (comment)

To clarify, who needs to be paid here and why? Thanks!

[abdulrahuman5196]

@isabelastisser This was regression fix. So no Contributor pay and C+ pay.

Not sure on the issue reporter payment in this case. Could you kindly check and process reporter payment alone if applicable?

[melvin-bot]

@isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[isabelastisser]

bump @Pujan92 and @kavimuru, please follow up on my questions:

#18597 (comment)

[Pujan92]

@isabelastisser As it was the regression from the @abdulrahuman5196's PR #15672. Seems the payment was triggered because this regression issue is linked to the PR and fixed. So I think only the reporter needs to be get paid here.

[isabelastisser]

Thanks for clarifying, @abdulrahuman5196 and @Pujan92!

[isabelastisser]

Regression fix by: @avi-shek-jha
Upwork job: https://www.upwork.com/jobs/~013149b74e65c279b3

@avi-shek-jha, please apply for this job and I will process the payment asap. Thanks!

[avi-shek-jha]

@isabelastisser It shows me error as 'access denied'. Here's my upwork profile : https://www.upwork.com/freelancers/~01a90e548bf808418c

Can you send me an invitation?

Thanks

[isabelastisser]

@avi-shek-jha all set in Upwork, thanks!

[abdulrahuman5196]

Just a note @isabelastisser

Regression fix by: @avi-shek-jha
Upwork job: https://www.upwork.com/jobs/~013149b74e65c279b3

Not fix but reporting bonus.

[avi-shek-jha]

@isabelastisser Submitted the work in Upwork. Thanks.