[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-22] Request Money - Account list for New Chat or Request money is not displayed while offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login
2. Click + New Chat
3. Observe you can see possible contacts
4. Go offline
5. Click + Request money

Expected Result:

List of possible accounts should be displayed

Actual Result:

Skeleton is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.13.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_79.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

Hmm I just tried this in staging web, v1.3.13-0 - and I was able to request money no problem while offline

[Beamanator]

@PauloGasparSv do you have time to get to this today / soonish? If not, do you mind dropping it in #engineering-chat to see who can investigate quick? 🙏

[PauloGasparSv]

Taking a look at this right now @Beamanator : )

[Beamanator]

You're the best!!

[PauloGasparSv]

Hmm I just tried this in staging web, v1.3.13-0 - and I was able to request money no problem while offline

This is also working for me and I can't replicate this. Pretty confused here, only tested Web so far but the video evidence is from Web so IMO that's ok.

Video evidence

Screen.Recording.2023-05-11.at.14.14.20.mov

Screen.Recording.2023-05-11.at.14.16.05.mov

Also tested on v1.3.13.0

@kbecciv can you double-check if this is still happening? If not let's close this : )
Also please share console logs if the error persists!

[PauloGasparSv]

Oh wait a second, this problem may not be happening to everyone according to this discussion so maybe that's why we can't replicate this @Beamanator

[PauloGasparSv]

Yes, sorry for that! This isn't happening to my paulo@expensify.com account but happens to paulo@expensifail.com in a different session here.

This is a little tricky because I can't replicate the problem using the "Offline" preset in the Network tab but only by turning my computer's wifi off.

Sorry for the previous comment @kbecciv, investigating this again here.

[PauloGasparSv]

This may have been introduced by #17349. Coming from this discussion I've assigned @aimane-chnaif here to create fix P.R. (thanks so much)

cc @amyevans

[PauloGasparSv]

Waiting on another +1 review for #18788 (comment)

We discussed this review in slack here and it was also mentioned here.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

This should be fixed in staging, adding Bug label to help with payments

@aimane-chnaif Can you help us say if there are any payments here, its not clear to me given it was a regression, thanks!

[aimane-chnaif]

@aimane-chnaif Can you help us say if there are any payments here, its not clear to me given it was a regression, thanks!

This is a regression but this was from discussed logic and not able to reproduce in PR review.
So I'd say no payment is here but hope won't affect payment in original issue because of the following reason:

• couldn't be caught earlier before PR merge (I think this came from recent backend update where returns bad contacts data, maybe related to [HOLD for payment 2023-05-23] [$1000] DEV: Search items show weird undefined texts #18860)
• fixed the issue myself

[mountiny]

Gotcha, so I will close this issue out and note on the original issue, thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix skeleton loading forever on options list when offline #18788

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix skeleton loading forever on options list when offline #18788

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: