[HOLD for payment 2023-06-02] [$1000] DEV: console error on complete Two-factor authentication

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go Settings > Security >Two-factor authentication
2. clear step1 and step 2
3. check the console on Step 3

Expected Result:

should not show any console error

Actual Result:

shows console error

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: DEV
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-18.at.6.09.04.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684391658242179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6f56e0c6d468dcd
• Upwork Job ID: 1660696773409353728
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on lottie view

What is the root cause of that problem?

This is a small regression from #14393
happens on this line:

App/src/components/ConfirmationPage.js

Line 13 in 8180113

animation: PropTypes.string,

Before, it was gif and required string to be passed as uri in image source.
After that PR, it was replaced with lottie which requires json.

What changes do you think we should make in order to solve the problem?

add more type: PropTypes.object

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6f56e0c6d468dcd

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[abdulrahuman5196]

@situchan Could you kindly add more information on what do you mean by add more type: PropTypes.object here #19365 (comment)?
It would be better to add what is the change and where is the change you are expected to make to solve this issue.

Note: I have assumption on your proposal, but I don't want to go with assumption. And it would be better for future references as well if we have more information on fixes in the proposal.

[situchan]

@abdulrahuman5196 I just avoided code diff.

App/src/components/ConfirmationPage.js

Line 13 in 8180113

animation: PropTypes.string,

This will be final change: animation: PropTypes.oneOfType([PropTypes.object, PropTypes.string]),

[abdulrahuman5196]

@situchan Why do we want both PropTypes.object and PropTypes.string? Isn't object alone enough?

[situchan]

string is also acceptable

[abdulrahuman5196]

I am not sure if we need to support all the types supported by lottie through the ConfirmationPage. I think its just fine to support only object which we use. But anyways I am fine with both since its a very subtle difference. What do you think @puneetlath ?
PropTypes.oneOfType([PropTypes.object, PropTypes.string]) or PropTypes.object (if no other issues)

@situchan Could you kindly update your proposal based on the discussion for future references.

Anyways the above comment is more like a PR comment. I tested and the changes are working fine.
So I am going ahead with approving the proposal here - #19365 (comment)

🎀👀🎀
C+ Reviewed
cc: @puneetlath

[puneetlath]

Let's make it strict to the only thing we currently use. If it needs to be made less strict later, we can do that.

[melvin-bot]

📣 @situchan You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

🎯 ⚡️ Woah @abdulrahuman5196 / @situchan, great job pushing this forwards! ⚡️

The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @situchan got assigned: 2023-05-23 19:09:15 Z
• when the PR got merged: 2023-05-24 22:29:12 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix invalid prop type of animation on tfa auth success #19525

If no regressions arise, payment will be issued on 2023-06-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @gadhiyamanan
• Contributor that fixed the issue @situchan
• Contributor+ that helped on the issue and/or PR @abdulrahuman5196

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

Contracts sent!

@abdulrahuman5196 friendly reminder on the checklist.

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:

#14393

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#14393 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Not required IMO, since its a minor console error and already we have checklist item to verify if no console errors are present.

@puneetlath Checklist complete and accepted contracts

[puneetlath]

All paid. Thanks everyone!