[HOLD for payment 2023-06-30] [$1000] Android - Share code - Copied link has NOT staging label

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19249

Action Performed:

1. Open the App
2. Login with any account
3. Go to settings > Share code
4. Click on "Copy URL to clipboard"
5. Go any chat.
6. Paste the link.
7. Verify that the url is treated as a link

Expected Result:

Copied link has staging label

Actual Result:

Copied link has NOT staging label

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/f2c90b9aef4ae82b8e2a172f074f90a3824b4b9a476747a628ef41eed4bafad8

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01015fed2b575db172
• Upwork Job ID: 1661856374223589376
• Last Price Increase: 2023-06-08

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

@kbecciv I don't see this issue when I try it, or at least I am not seeing different things in each account. I sent the link from staging on one account, and it didn't show staging in the URL. Then when I went to the recipient's account I also didn't see staging.

Is the issue that the URL is different in one view v. the other, or that it should showing staging in both URLs?

[kevinksullivan]

got clarity in slack, moving on!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01015fed2b575db172

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @alex-mechler (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Share Code - Copied link does not have staging label on Android native builds.

What is the root cause of that problem?

The root cause of the problem is that we are not using the Environment to decide on the URL.

What changes do you think we should make in order to solve the problem?

The following changes need to be done in ShareCodePage file

a) Use the withEnvironment component

import withEnvironment, {environmentPropTypes} from '../components/withEnvironment';

Using withEnvironment will make sure that the property this.props.environment with refer to correct environment for the specific platform on which the app is running. Specifically, for native devices, this funcionality will also take into consideration the mode (i.e. beta/prod) in which the app is running and decide the appropriate environment.

b) Use the this.props.environment and construct the share code url by replace this line with the following:

const environmentURL = (this.props.environment === CONST.ENVIRONMENT.STAGING) ?  Url.addTrailingForwardSlash(CONST.STAGING_NEW_EXPENSIFY_URL) : CONST.NEW_EXPENSIFY_URL;
const url = isReport ? `${environmentURL}r/${this.props.report.reportID}` : `${environmentURL}details?login=${encodeURIComponent(this.props.session.email)}`;

We use the staging url only for the staging environment and use the production url for all other environments as production url is the default URL.

Result

19464_android-native_prod.mp4

19464_android-native_stag.mp4

What alternative solutions did you explore? (Optional)

[mananjadhav]

@rojiphil I think I agree with the .env file changes but I am not convinced if we should just change it to .env.staging for debug mode. The reason being, what if I am running a local build?

apply from: project(":react-native-config").projectDir.getPath() + "/dotenv.gradle"

And what's the reasoning for changing the filepath from top to bottom?

[rojiphil]

@mananjadhav Thanks for your feedback.

And what's the reasoning for changing the filepath from top to bottom?

Adding at the top does not help in reading the config file whereas adding to the bottom helps. Attaching the build output for your reference.

I think I agree with the .env file changes but I am not convinced if we should just change it to .env.staging for debug mode. The reason being, what if I am running a local build?

Not sure if I understood your comment correctly. Did you mean the local release build as shown here?

[mananjadhav]

Not the local release build, but local debug build will always use staging env? I don't think we would want that.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kevinksullivan]

@flodnv added engineering label to have someone step in on the PR review for Alex.

#21107

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @rojiphil got assigned: 2023-06-14 19:00:23 Z
• when the PR got merged: 2023-06-21 16:48:06 UTC
• days elapsed: 5

On to the next one 🚀

[kevinksullivan]

Waiting 6 days for any regressions

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Share Code URL implementation using Environment URL #21107

If no regressions arise, payment will be issued on 2023-06-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[anmurali]

Paid @mananjadhav on New Dot

[rojiphil]

@kevinksullivan Gentle reminder as I am also awaiting payment.

[kevinksullivan]

hi @mananjadhav can you finish out the steps above please? Thanks!

[kevinksullivan]

@rojiphil sorry for the confusion here. A few weeks ago it seems I created another job for you but I'm not seeing it. Do you have an upwork job for this, and can you provide the link here? If not I'll just have to create another one.

[rojiphil]

@kevinksullivan Here is the link to the Upwork job.
I have also sent you a message on Upwork if that helps in tracking within Upwork.

[mananjadhav]

Yes @kevinksullivan, I'll post an update tomorrow.

[kevinksullivan]

Thanks @rojiphil , all set.

[rojiphil]

Thanks @kevinksullivan @mananjadhav @AndrewGable @alex-mechler @MelvinBot. This was my first contribution to Expensify. Love the fairness, transparency, and process-oriented approach here.

[mananjadhav]

Ohh that's good to hear @rojiphil. thanks for the patience on this one and appreciate your contribution. Welcome to the community. Looking forward to working with you more :)

[mananjadhav]

In this PR, we added a fixed variable NEW_EXPENSIFY, which isn't set based on the environment. I wouldn't treat this so much as bug as we were on the fence to even fix this. We fixed this for uniformity. I've posted the comment on the PR, but I don't see any action to be updated here.

I don't think we need a regression test for this one. @flodnv @kevinksullivan wdyt?

[flodnv]

Agreed

[kevinksullivan]

yup, agree @mananjadhav

[kevinksullivan]

Closing out!