Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed
62 tasks done
OSBotify opened this issue May 22, 2023 · 16 comments
Closed
62 tasks done

Deploy Checklist: New Expensify 2023-05-22 #19422

OSBotify opened this issue May 22, 2023 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 22, 2023

Release Version: 1.3.17-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 22, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.17-0 🚀

@mvtglobally
Copy link

@chiragsalian
We still dont have IOS build. Can you pls double check if Apple approved it

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.17-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.17-1 has been deployed to staging 🎉

@mvtglobally
Copy link

@chiragsalian Regression is still in progress. Current summary

PR #19101 is failing #19469. repro in PROD checking off
#19335 is failing #19462. We are not able to validate in PROD as number is not added. pls double check
#19333 is failing #19493. repro in PROD checking off

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.17-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.17-2 has been deployed to staging 🎉

@mvtglobally
Copy link

@chiragsalian Regression is completed

Blockers
#19440
#19482

PRs
#18847 (comment) checking off
#18523 (comment)
#19107 is failing #19470. Repro in PROD
#19128 (comment) can you pls help with internal QA
#19230 is failing #19494
#19249 is failing #19464. pls double check if not a blocker as we are unable to verify prod in a same way
#19335 is failing #19462. We are not able to validate in PROD as number is not added. pls double check

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.17-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.17-3 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

#19230 is a pass. Checking off.
Screenshot 2023-05-24 at 12 48 32 PM

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.17-5 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.17-5 has been deployed to staging 🎉

@mvtglobally
Copy link

mvtglobally commented May 24, 2023

#19294 is pass on all platforms but Desktop. We are blocked on Desktop and URL doesnt navigate to the Concierge. #19294 (comment)

@chiragsalian
Copy link
Contributor

I checked off some items as per the discussions here

@chiragsalian
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants