[$1000] mWeb/Safari - Connect Bank - Inscription Expensify Terms of Service moves

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Navigate to Settings -> Workspaces -> Click on any workspace -> Connect bank account -> Connect Manually
4. Long press on Expensify Terms of Service

Expected Result:

Inscription Expensify Terms of Service does NOT move (doubles)

Actual Result:

Inscription Expensify Terms of Service moves (doubles)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/0137a3fdd3dce14d399350ce36f8af5c52ce28e8664b69cfa336f4181a34d52d

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014e37c553b2b1eed3
• Upwork Job ID: 1661265433902952448
• Last Price Increase: 2023-05-24

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014e37c553b2b1eed3

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @cead22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

Regression from this PR:
#19101
The problem of this issue is when user long press the link, the Form triggered focus change and showed the error, made the link move down a little bit with the original position of it, after user released the mouse, it took a while for the link moved to the original position and then moved back to the new position which caused this issue. If we can keep the first position the same with the last position when releasing the mouse this issue won't happen.
The possible solution is to use onMouseDown with preventDefault() for TextLink. Please let me know how do you guys think? Thank you.
cc @mananjadhav @marcochavezf

Result:

Screen.Recording.2023-05-24.at.14.45.36.mov

[laurenreidexpensify]

@thesahindia do you agree that this is a regression as per @hungvu193's comment above?

[mananjadhav]

@laurenreidexpensify It is. I think Sahil is OOO, but I validated.

[laurenreidexpensify]

Thanks @mananjadhav

Note to self - asking a question here internally about this

[laurenreidexpensify]

Regression is fixed in this #19537 so closing