-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling Animations for contextMenu and EmojiPicker #19300
Enabling Animations for contextMenu and EmojiPicker #19300
Conversation
@mountiny @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@esh-g there are a few more instances to remove:
App/src/components/EmojiPicker/EmojiPicker.js Lines 144 to 145 in 8180113
As comment says, let's make sure it doesn't cause any performance regression after this change. Please thoroughly test on very old device which is very slow. |
Enabled Animation
Removed comments regarding animation
@aimane-chnaif I have made the suggested changes and I have tested on the oldest device I have, Redmi Note 5 pro, which was launched in 2018 and seems to work fine with that and also the iPhone SE(2020). Please let me know if you have some further concerns about older devices.. |
@esh-g ok, can you also add videos for reactions list modal? |
Yes, @aimane-chnaif Sorry for the delay, Should I just post the videos in a comment or edit the first PR comment and add a second video for all platforms along with an addition to the steps? |
Easier way you find. 2nd video is fine |
@esh-g also add more cases in Tests step |
I have updated the steps in the PR comment and also added a second video for each platform. |
"Right click/Long Press any report to open the context menu" Use report action or chat message |
Updated! @aimane-chnaif 👍 |
@esh-g I updated comment. Please check again |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemchrome.movMobile Web - Safarimsafari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
I still see "any report" in Step 2. |
@aimane-chnaif updated those steps for @esh-g are we looking good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Oh, I misunderstood... It is corrected now @aimane-chnaif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.17-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀
|
Details
Fixed Issues
$ #17982
PROPOSAL: #17982 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-05-19.at.9.27.26.PM.mov
Screen.Recording.2023-05-22.at.6.50.56.PM.mov
Mobile Web - Chrome
Screen.Recording.2023-05-19.at.9.38.32.PM.mov
Screen.Recording.2023-05-22.at.7.05.07.PM.mov
Mobile Web - Safari
Screen.Recording.2023-05-19.at.9.29.23.PM.mov
Screen.Recording.2023-05-22.at.6.52.39.PM.mov
Desktop
Screen.Recording.2023-05-19.at.9.55.17.PM.mov
Screen.Recording.2023-05-22.at.7.06.29.PM.mov
iOS
Screen.Recording.2023-05-19.at.9.20.17.PM.mov
Screen.Recording.2023-05-22.at.6.49.54.PM.mov
Android
Screen.Recording.2023-05-19.at.9.50.42.PM.mov
Screen.Recording.2023-05-22.at.7.03.08.PM.mov