Upgrade reanimated to 3.1.0 #18073

terrysahaidak · 2023-04-27T10:38:26Z

Details

Reanimated upgrade is required to unblock #16356

In this PR I also fixed some of the bugs in the code, but also used patch-package for iOS to address the crash we had, it was resolved in a recent PR software-mansion/react-native-reanimated#4403 and touches only iOS files so it's safe to use patch-package.

We decided to use patch-package here.

Reanimated is used on mobile (iOS and Android)

Fixed Issues

$ GH_LINK
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

I tested all components that use Reanimated on both iOS and Android:

Drawer navigation
Avatar crop view
Opacity view (fade-in for the chat)
Emoji picker categories
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

No changes

Mobile Web - Chrome

No changes

Mobile Web - Safari

No changes

Desktop

No changes

iOS

No changes

Android

No changes

terrysahaidak · 2023-05-02T09:08:54Z

Unfortunately, upgrading Reanimated to 3.1.0 results into a crash when navigating to the chat.

This seems to be related to this issue: software-mansion/react-native-reanimated#2285

Looking into the cause, maybe it reproduces and fix this crash

/cc @tomekzaw

2023-05-02.12.07.29.mov

Crash log

2023-05-02 11:59:26.085353+0300 New Expensify[89330:15255769] [db] Failed to initialize client context with error Error Domain=NSOSStatusErrorDomain Code=-10817 "(null)" UserInfo={_LSFunction=_LSSchemaConfigureForStore, ExpectedSimulatorHash={length = 32, bytes = 0xed662242 5fb7c0a8 1bf3f783 33b5c275 ... 5cef5e61 5d97a96c }, _LSLine=478, WrongSimulatorHash={length = 32, bytes = 0x3190f8e7 217931fc b7f7be3d 298bbb9a ... 8472784b 30a84b1d }}
2023-05-02 11:59:27.371684+0300 New Expensify[89330:15256703] [connection] nw_socket_handle_socket_event [C28.1.1:1] Socket SO_ERROR [61: Connection refused]
2023-05-02 11:59:27.373096+0300 New Expensify[89330:15256703] [connection] nw_socket_handle_socket_event [C28.1.2:1] Socket SO_ERROR [61: Connection refused]
2023-05-02 11:59:27.373705+0300 New Expensify[89330:15256736] [connection] nw_connection_get_connected_socket_block_invoke [C28] Client called nw_connection_get_connected_socket on unconnected nw_connection
2023-05-02 11:59:27.373803+0300 New Expensify[89330:15256736] TCP Conn 0x6000029d8000 Failed : error 0:61 [61]
2023-05-02 11:59:27.862229+0300 New Expensify[89330:15255878] [javascript] [info] Navigating to route - {"path":"/r/8298938939997591"}
2023-05-02 11:59:29.050415+0300 New Expensify[89330:15255878] [javascript] [info] Navigating to route - {"path":"/r/8298938939997591"}
2023-05-02 11:59:29.101225+0300 New Expensify[89330:15255769] *** Assertion failure in -REANodesManager uiManager:performMountingWithBlock:, /Users/terrysahaidak/Projects/margelo/Expensify/App/node_modules/react-native-reanimated/ios/REANodesManager.mm:246
2023-05-02 11:59:29.113192+0300 New Expensify[89330:15255769] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Mouting block is expected to not be set'
*** First throw call stack:
(
0 CoreFoundation 0x000000011bbdb378 __exceptionPreprocess + 242
1 libobjc.A.dylib 0x0000000112fd1baf objc_exception_throw + 48
2 Foundation 0x000000011916e851 -[NSMutableDictionary(NSMutableDictionary) classForCoder] + 0
3 New Expensify 0x0000000104d97fe1 -[REANodesManager uiManager:performMountingWithBlock:] + 289
4 New Expensify 0x0000000104f8d651 -[RCTUIManagerObserverCoordinator uiManager:performMountingWithBlock:] + 529
5 New Expensify 0x0000000104f87502 -[RCTUIManager flushUIBlocksWithCompletion:] + 626
6 New Expensify 0x0000000104f87210 -[RCTUIManager _layoutAndMount] + 832
7 New Expensify 0x0000000104f86ec1 -[RCTUIManager batchDidComplete] + 33
8 New Expensify 0x0000000104d9735f -[RCTUIManager(SyncUpdates) runSyncUIUpdatesWithObserver:] + 335
9 New Expensify 0x0000000104d98727 __36-[REANodesManager performOperations]_block_invoke + 695
10 New Expensify 0x0000000104f8dfdd __RCTExecuteOnUIManagerQueue_block_invoke + 29
11 libdispatch.dylib 0x000000011eb2bd18 _dispatch_call_block_and_release + 12
12 libdispatch.dylib 0x000000011eb2cf5b _dispatch_client_callout + 8
13 libdispatch.dylib 0x000000011eb34d41 _dispatch_lane_serial_drain + 1064
14 libdispatch.dylib 0x000000011eb35b1b _dispatch_lane_invoke + 441
15 libdispatch.dylib 0x000000011eb43f13 _dispatch_workloop_worker_thread + 959
16 libsystem_pthread.dylib 0x000000011f962ce3 _pthread_wqthread + 326
17 libsystem_pthread.dylib 0x000000011f961c67 start_wqthread + 15
)
libc++abi: terminating with uncaught exception of type NSException
Message from debugger: Terminated due to signal 6

terrysahaidak · 2023-05-02T09:51:33Z

Found the cause of the crash:

https://github.com/Expensify/react-navigation/blob/main/packages/drawer/src/views/modern/Overlay.tsx#L24

Commenting out this line resolves the crash.

terrysahaidak · 2023-05-02T10:16:55Z

Unfortunately, android in release mode has another bug even after resolving that one:

terrysahaidak · 2023-05-02T15:20:17Z

After testing can confirm this PR fixes our iOS crash:
https://github.com/software-mansion/react-native-reanimated/pull/4403/files

terrysahaidak · 2023-05-03T16:27:43Z

In the meantime we used patch-package to fix the crash on iOS.

MelvinBot · 2023-05-04T09:11:31Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MariaHCD

Looks good to me! Tagging @roryabraham for another set of eyes on this.

MariaHCD · 2023-05-05T08:07:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

roryabraham · 2023-05-05T23:14:43Z

Reanimated is used on mobile (iOS and Android)

It's used on web as well 🙂

src/components/AvatarCropModal/ImageCropView.js

src/pages/home/report/ReportActionsList.js

src/components/AvatarCropModal/Slider.js

roryabraham · 2023-05-06T19:17:01Z

Also, the tests failing on this branch are weird. I think it's to do with setimmediate being removed as a dependency of Reanimated. Trying to track down the story there (I thought that setImmediate was built-in to JavaScript)

roryabraham · 2023-05-06T19:18:21Z

Yeah, definitely not a standard thing: https://caniuse.com/?search=setImmediate

terrysahaidak · 2023-05-06T19:21:11Z

Yeah, definitely not a standard thing: https://caniuse.com/?search=setImmediate

very interesting, worth submitting an issue in their repo, I'll do it on Monday, setTimeout should cover it though.

roryabraham · 2023-05-06T19:23:44Z

software-mansion/react-native-reanimated#4276

roryabraham · 2023-05-06T20:36:19Z

You can fix some of the failing tests by:

Installing the setimmediate polyfill as a dev dependency.
Doing import 'setimmediate'; in the first line of jest/setup.js

But still UnreadIndicatorsTest is failing. More investigation is needed.

terrysahaidak · 2023-05-06T20:38:04Z

Yeah I'll look into it for sure. I tested everything locally and it worked well so falling tests are a surprise.

terrysahaidak · 2023-05-08T13:06:30Z

Yes, adding isConfigured to Reanimated 2 mocks fixes tests.

We can of course just add another patch for this. But isConfigured is not a public API, so it should not be used in the Drawer anyway - since it's now working.

But also, legacy API should not work in the Drawer anyway, since it's a long time deprecated and should be removed.

…ade-reanimated

roryabraham · 2023-05-10T17:18:53Z

package.json

@@ -131,6 +131,7 @@
    "react-web-config": "^1.0.0",
    "save": "^2.4.0",
    "semver": "^7.3.8",
+    "setimmediate": "^1.0.5",


Oh, I think this should be a dev dependency since it's only needed by jest?

yeah makes sense, hope no one's gonna use it in the app though

…ade-reanimated

terrysahaidak · 2023-05-11T06:59:14Z

package.json

+        "react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#107b3786ae6bc155dec05c7fc5ee525d3421dc21",
+        "react-native-plaid-link-sdk": "^10.0.0",
+        "react-native-quick-sqlite": "^8.0.0-beta.2",
+        "react-native-reanimated": "3.1.0",


prettier screwed the diff
new reanimated version here

terrysahaidak · 2023-05-11T07:00:20Z

package.json

+        "react-native-performance-flipper-reporter": "^2.0.0",
+        "react-native-svg-transformer": "^1.0.0",
+        "react-test-renderer": "18.1.0",
+        "setimmediate": "^1.0.5",


and setimmediate as a dev dependency since it used to be part of reanimated and is still used in tests right now

roryabraham · 2023-05-11T20:43:33Z

Sorry @terrysahaidak, you've got conflicts again

terrysahaidak · 2023-05-11T20:50:28Z

@roryabraham it looks like some of the branches still have non-formatted package.json

…ade-reanimated

terrysahaidak · 2023-05-11T20:55:02Z

Used the same 2-space indentation as the code on main so it's not causing more problems for now, but it might need lint-staged to check for prettier formatting on merge at least

roryabraham

@terrysahaidak I'm getting a prettier diff on this branch

terrysahaidak · 2023-05-15T14:39:55Z

@roryabraham looks to be ready to go

roryabraham · 2023-05-18T19:09:09Z

Sorry for the delay, reviewing now

roryabraham · 2023-05-18T19:14:33Z

Running ad-hoc test build: https://github.com/Expensify/App/actions/runs/5017429511

OSBotify · 2023-05-18T20:18:23Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/18073/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/18073/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/18073/NewExpensify.dmg	https://18073.pr-testing.expensify.com

roryabraham · 2023-05-18T23:27:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

RPReplay_Final1684452532.MP4

Android

screen-20230518-163346.mp4

roryabraham · 2023-05-18T23:41:04Z

@MariaHCD I'm going to finish your checklist to make the PR checks pass

OSBotify · 2023-05-18T23:51:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:51:33Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mvtglobally · 2023-05-23T03:46:09Z

@roryabraham @MariaHCD Do we need to QA anything here?

MariaHCD · 2023-05-23T06:48:52Z

@mvtglobally I think it would be good to QA the following on iOS and Android (specifically the animation):

Drawer navigation & Opacity view (fade-in for the chat): i.e. opening a chat and then swiping to navigate back to the LHN , navigating through Settings menu items, etc.
Avatar crop view: uploading a new avatar image and cropping/resizing it
Emoji picker categories: the animation when clicking on emoji categories

OSBotify · 2023-05-25T00:23:25Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

terrysahaidak mentioned this pull request May 2, 2023

When you long-press on a message in iOS mobile, the message moves out of the screen frame and is hidden (iOS only) #16356

Closed

54 tasks

terrysahaidak added 5 commits May 3, 2023 19:18

Upgrade reanimated to 3.1.0

084904f

Fix recursive crash on Android

249ef57

Refactor ReportActionList to use more common Reanimated API

6422ca5

Podfile changes after upgrade

020667b

Fix another props usage inside useAnimatedStyle

a3485a7

terrysahaidak force-pushed the @terrysahaidak/upgrade-reanimated branch from a8f6a30 to a3485a7 Compare May 3, 2023 16:20

Add iOS crash patch

97bd3f0

terrysahaidak marked this pull request as ready for review May 4, 2023 09:10

terrysahaidak requested a review from a team as a code owner May 4, 2023 09:10

melvin-bot bot requested review from MariaHCD and removed request for a team May 4, 2023 09:11

MariaHCD assigned terrysahaidak May 5, 2023

MariaHCD reviewed May 5, 2023

View reviewed changes

MariaHCD requested a review from roryabraham May 5, 2023 08:04

roryabraham requested changes May 6, 2023

View reviewed changes

src/components/AvatarCropModal/ImageCropView.js Show resolved Hide resolved

src/components/AvatarCropModal/ImageCropView.js Show resolved Hide resolved

src/pages/home/report/ReportActionsList.js Show resolved Hide resolved

src/components/AvatarCropModal/Slider.js Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into @terrysahaidak/upgr…

f536009

…ade-reanimated

roryabraham requested changes May 10, 2023

View reviewed changes

terrysahaidak added 3 commits May 10, 2023 22:44

Add patch for missing isConfigured to reanimated mock to pass tests

aa85d02

move setimmediate to dev dependencies since it's used only by jest

a3eb8e6

Merge remote-tracking branch 'upstream/main' into @terrysahaidak/upgr…

8c96f37

…ade-reanimated

terrysahaidak commented May 11, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into @terrysahaidak/upgr…

c47f847

…ade-reanimated

roryabraham requested changes May 12, 2023

View reviewed changes

roryabraham mentioned this pull request May 12, 2023

[No QA] Enforce there's no prettier diff in PR checks #18820

Merged

57 tasks

prettify code

5f8ff9c

roryabraham added the Ready To Build label May 18, 2023

roryabraham approved these changes May 18, 2023

View reviewed changes

roryabraham merged commit 78ec531 into Expensify:main May 18, 2023

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

Upgrade reanimated to 3.1.0 #18073

Upgrade reanimated to 3.1.0 #18073

Conversation

terrysahaidak commented Apr 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

terrysahaidak commented May 2, 2023

terrysahaidak commented May 2, 2023

terrysahaidak commented May 2, 2023

terrysahaidak commented May 2, 2023

terrysahaidak commented May 3, 2023

MelvinBot commented May 4, 2023

MariaHCD left a comment

Choose a reason for hiding this comment

MariaHCD commented May 5, 2023 • edited by roryabraham Loading

Reviewer Checklist

Screenshots/Videos

roryabraham commented May 5, 2023

roryabraham commented May 6, 2023

roryabraham commented May 6, 2023

terrysahaidak commented May 6, 2023

roryabraham commented May 6, 2023

roryabraham commented May 6, 2023

terrysahaidak commented May 6, 2023

terrysahaidak commented May 8, 2023

roryabraham May 10, 2023

Choose a reason for hiding this comment

terrysahaidak May 11, 2023

Choose a reason for hiding this comment

terrysahaidak May 11, 2023

Choose a reason for hiding this comment

terrysahaidak May 11, 2023

Choose a reason for hiding this comment

roryabraham commented May 11, 2023

terrysahaidak commented May 11, 2023

terrysahaidak commented May 11, 2023

roryabraham left a comment

Choose a reason for hiding this comment

terrysahaidak commented May 15, 2023

roryabraham commented May 18, 2023

roryabraham commented May 18, 2023

OSBotify commented May 18, 2023

roryabraham commented May 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

roryabraham commented May 18, 2023

OSBotify commented May 18, 2023

OSBotify commented May 22, 2023

mvtglobally commented May 23, 2023

MariaHCD commented May 23, 2023

OSBotify commented May 25, 2023

terrysahaidak commented Apr 27, 2023 •

edited

Loading

MariaHCD commented May 5, 2023 •

edited by roryabraham

Loading

roryabraham commented May 18, 2023 •

edited

Loading