Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-05-26 #19657

Closed
32 tasks done
OSBotify opened this issue May 26, 2023 · 24 comments
Closed
32 tasks done

Deploy Checklist: New Expensify 2023-05-26 #19657

OSBotify opened this issue May 26, 2023 · 24 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 26, 2023

Release Version: 1.3.19-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 26, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.19-2 🚀

@mvtglobally
Copy link

mvtglobally commented May 29, 2023

Regression is completed

#18454 is failing #19685
#18662 is failing #19688 , #19713
#19117 is failing #19697
#19428 is failing #19691, #19687
#19512 is failing #19692

#19434 (comment)

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.19-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.19-3 has been deployed to staging 🎉

@luacmartins luacmartins added the Daily KSv2 label May 29, 2023
@luacmartins luacmartins self-assigned this May 29, 2023
@luacmartins
Copy link
Contributor

I'll take this over for today, since it's a holiday in the UK/US

@luacmartins
Copy link
Contributor

Just tested #19680 in staging and it seems to work. Checking it off.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.19-5 🚀

@luacmartins
Copy link
Contributor

Tested #19748 and #18454. It's a pass, checking it off.

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.19-5 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Fix for #18662 is here

@luacmartins
Copy link
Contributor

We have a fix up for #19697, checking #19117 off

@luacmartins
Copy link
Contributor

#19428 we fixed one of the issues and the other doesn't seem to be reproducible. Checking it off.

@luacmartins
Copy link
Contributor

#19512 the reported issue is not a bug. Checking off.

@luacmartins
Copy link
Contributor

#19434 is prod QA. Checking off.

@luacmartins
Copy link
Contributor

I see 2 new crashes in Crashlytics. I have fixes for both of them

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.19-6 🚀

@luacmartins
Copy link
Contributor

Tested #19758 and it's a pass. Checking off.

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.19-6 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.19-7 🚀

@luacmartins
Copy link
Contributor

Tested #19759 in staging. It's a pass. Checking off.

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.19-7 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Checklist is complete. Kicking off the deploy.

@luacmartins
Copy link
Contributor

:shipit:

@Julesssss
Copy link
Contributor

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants