Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Chat - Keyboard stays open in details page #19691

Closed
1 of 6 tasks
kbecciv opened this issue May 26, 2023 · 19 comments
Closed
1 of 6 tasks

mWeb - Chat - Keyboard stays open in details page #19691

kbecciv opened this issue May 26, 2023 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented May 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #19428

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Open group > send message > react with 2 or more accounts
  4. Hover over the members in the list
  5. Click on the user
  6. Notice it should open the user detail page

Expected Result:

The keyboard collapses when you go to the details page

Actual Result:

Keyboard stays open in details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.19.2

Reproducible in staging?: yes

Reproducible in production?: ew feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/e840decd40039193643fd7e4d4ff03d875118d416c86dfb1beda4c7d773a8779

https://platform.applause.com/services/links/v1/external/bba2d198b3761a3e16ff1e2bd872ff6519a6850d0db02e615edaab641688f571

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b5bed8070cd317b5
  • Upwork Job ID: 1672335678406971392
  • Last Price Increase: 2023-06-23
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@joekaufmanexpensify
Copy link
Contributor

@kbecciv as it stands right now, I cannot reproduce this based on the steps included above. The keyboard is closing for me when I do this. However, the steps above were not 100% clear to me, and it's difficult to validate whether the exact actions I took are correct, because there is no video on the bug report.

2023-05-26_15-46-17.mp4

@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented May 26, 2023

I'm going to assign this back to you for now. If the video I posted above is not what you intended with the above reproduction steps, could you please add a video showing the exact actions you took to encounter this issue?
If my video is correct, and you can no longer reproduce this, please close the issue.

If you add a video to this issue between 2023-05-27 - 2023-06-05, please remove and re-add the bug label so someone else is assigned, as I'll be OOO then. Then, please assign me as an additional assignee too.

Otherwise, please feel free to just re-assign me. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

@kbecciv Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

@kbecciv Eep! 4 days overdue now. Issues have feelings too...

@kbecciv
Copy link
Author

kbecciv commented Jun 1, 2023

@joekaufmanexpensify Checking with QA team, will update you shortly

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@kbecciv
Copy link
Author

kbecciv commented Jun 1, 2023

Issue is reproductible in build 1.3.22.0

Record_2023-06-01-16-02-12.mp4

Screenshot_2023-06-01-16-02-34-97_40deb401b9ffe8e1df2f1cc5ba480b12

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

@kbecciv Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

@kbecciv Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

@kbecciv this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

@kbecciv 10 days overdue. I'm getting more depressed than Marvin.

@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

@kbecciv 12 days overdue. Walking. Toward. The. Light...

@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

@kbecciv this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Engineering Weekly KSv2 and removed Daily KSv2 labels Jun 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

This issue has not been updated in over 14 days. @kbecciv eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

@kbecciv this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 labels Jun 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b5bed8070cd317b5

@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@joekaufmanexpensify
Copy link
Contributor

joekaufmanexpensify commented Jun 23, 2023

@kbecciv Thanks for retesting this! The video was super helpful to to see the specific steps you were taking. I tested these specific steps on my end again now on V1.3.31-1 and cannot reproduce this. The keyboard is closing automatically for me when I take the action outlined above (you can see it for a second, but the momentary flicker of it closing doesn't feel like a bug to me, as it is closing automatically, and that's just the loading animation).

2023-06-23_17-29-35.mp4

Going to close this one for now, as I'm unable to reproduce this with the updated steps. If you can still reproduce this on the updated version, please re-open it, and I will get a secondary reviewer to try and reproduce as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants