[HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Previewing Concierge shows different image in compared to group chat and search

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Search for Concierge and notice that on search, the Concierge is displayed in green color avatar
3. Click on it so that the chat page appears. Click on the Concierge image to preview it and notice that on preview it appears a blue image
4. Even in a group chat, it appears as green avatar but if you try to preview it, it appears as a blue image

Expected Result:

Image should be consistent everywhere

Actual Result:

Previewing Concierge shows different image in compared to group chat and search

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-09_00.36.18.mp4

Recording.916.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686250700849029

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

I can reproduce on staging web

[AndrewGable]

Coming from https://staging.expensify.com/api?command=OpenPublicProfilePage

https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2021.png

[Beamanator]

PR that created that command: https://github.com/Expensify/Web-Expensify/pull/37712

[AndrewGable]

Somehow we need to update Concierge's avatar to this image: https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2022.png

@puneetlath I think it came from your PR: #20144

[Beamanator]

I'll help investigate for @puneetlath 👍

[AndrewGable]

I think I have access to log into concierge@ in Expensify.com, I could just try setting the avatar in the UI? But I do think this will change the avatar for a lot of different UI elements I might think?

[Beamanator]

Hmm that could work but ya I think we hardcode the concierge avatar in App in a lot of places

[Beamanator]

one example:

App/src/libs/OptionsListUtils.js

Lines 189 to 191 in 38ba7c8

	if (login === CONST.EMAIL.CONCIERGE) {
	personalDetail.avatar = CONST.CONCIERGE_ICON_URL;
	}

[Beamanator]

So I think we should either hardcode the concierge avatar everywhere in App, or update Concierge's avatar like you said :D

[Beamanator]

Discussing in slack: https://expensify.slack.com/archives/C03TQ48KC/p1686253332687619

[AndrewGable]

Sounds like we are preferring to hard code this, I'll look into where is the best to do so

[AndrewGable]

PR up

[AndrewGable]

CP-ed, removing label

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add a check for Concierge default avatar #20483

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@AndrewGable] The PR that introduced the bug has been identified. Link to the PR:
• [@AndrewGable] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@AndrewGable] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@AndrewGable] Determine if we should create a regression test for this bug.
• [@AndrewGable] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[avi-shek-jha]

@AndrewGable Is this new issue regression from the current issue https://expensify.slack.com/archives/C049HHMV9SM/p1686637757270519

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add a check for Concierge default avatar #20483

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@AndrewGable] The PR that introduced the bug has been identified. Link to the PR:
• [@AndrewGable] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@AndrewGable] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@AndrewGable] Determine if we should create a regression test for this bug.
• [@AndrewGable] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[AndrewGable]

I fixed this

[priya-zha]

@AndrewGable I'm the external reporter for this issue.

[AndrewGable]

@sonialiap - Can you please pay @priya-zha the reporting bonus? Thank you

[sonialiap]

@priya-zha offer sent

Reopening so that I can keep track of this issue

[priya-zha]

@sonialiap Accepted. Thanks.

[sonialiap]

Paid ✅