Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed
74 tasks done
OSBotify opened this issue Jun 8, 2023 · 15 comments
Closed
74 tasks done

Deploy Checklist: New Expensify 2023-06-08 #20466

OSBotify opened this issue Jun 8, 2023 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2023

Release Version: 1.3.26-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@roryabraham roryabraham added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 8, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 8, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.26-1 🚀

@isagoico
Copy link

isagoico commented Jun 9, 2023

Left a comment for #20247 (comment) - we're unsure on how to execute the QA steps there.

@isagoico
Copy link

isagoico commented Jun 9, 2023

#19612 is failing because of this issue #20513

Update:
#19664 is failing because of #20495

@isagoico
Copy link

isagoico commented Jun 9, 2023

Going to check off #20107 as it was a pass on every platform except Android.
Android is failing because of this issue #17368 (that was not being fixed on that PR)

@mvtglobally
Copy link

mvtglobally commented Jun 9, 2023

Regression is almost completed

#19612 is failing because of this issue #20513
#19664 is failing because of #20495
#19879 is failing because of #20521
#19883 is failing because of #20509
#19946 is failing due to #20523. Repro in PROD
#20088 iOS test pending
#20114 is failing due to #19483 & #19717 . Repro in prod
#20115 is failing due to #20505
#20144 is failing due to #19915. Repro in prod
#20246 is failing due to #20530, repro in prod
#20247 is blocked. #20247 (comment) - we're unsure on how to execute the QA steps there.
#20440 is failing due to #20492

@Julesssss
Copy link
Contributor

Julesssss commented Jun 12, 2023

We're not sure why #20505 was reported as a bug, would you mind double checking it please? In the meantime I checked off #20115.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.26-2 🚀

@mvtglobally
Copy link

Regression is completed.

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.26-2 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.26-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.26-3 has been deployed to staging 🎉

@mvtglobally
Copy link

New Blocker added as validating CPs #20609

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jun 12, 2023
@PauloGasparSv
Copy link
Contributor

Checking #20583 off since we CP'd a fix P.R. to staging

@dangrous
Copy link
Contributor

Checking #20609 off - it is a bug but seems not to be a deploy blocker - spawns from code already on prod (which is just currently blocked fully by another bug)

@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants