Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] URL appears as html in thread title and alternate text in search page #20520

Closed
6 tasks done
kavimuru opened this issue Jun 9, 2023 · 29 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Jun 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Send a website url
  3. Hover and click on thread icon
  4. See the header
  5. Go to search and search "<a"

Expected Result:

Normal text should be shown

Actual Result:

URL shows in html format

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshot 2023-06-09 at 10 24 33 AM

Screenshot (367)

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686286858935369

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b674a204efbb9b04
  • Upwork Job ID: 1671168762113949696
  • Last Price Increase: 2023-06-20
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

@grgia is out for the weekend, going to grab this.

@roryabraham
Copy link
Contributor

I confirmed that this bug is caused in the back-end. The root cause is that the text for the reportAction is being overwritten by HTML.

If you take these same actions offline, it will work.

@roryabraham
Copy link
Contributor

That means that, if it's not too late, this should actually be a deploy blocker for the API, not E/App.

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Jun 10, 2023
@roryabraham
Copy link
Contributor

Going to create an internal deploy blocker

@roryabraham
Copy link
Contributor

@roryabraham
Copy link
Contributor

PR to fix this ready here: https://github.com/Expensify/Web-Expensify/pull/37784

@roryabraham
Copy link
Contributor

@grgia requested your review on that PR because this issue was auto-assigned to you originally 😉

@roryabraham
Copy link
Contributor

This is fixed

@Puneet-here
Copy link
Contributor

@roryabraham, is this eligible for the reporting compensation?

@Puneet-here
Copy link
Contributor

@roryabraham, is this eligible for the reporting compensation?

cc: @johncschuster

@roryabraham roryabraham reopened this Jun 17, 2023
@roryabraham
Copy link
Contributor

Looks like @Puneet-here is eligible for the bug reporting bonus here.

@roryabraham roryabraham added Daily KSv2 and removed Hourly KSv2 labels Jun 17, 2023
@roryabraham
Copy link
Contributor

Sorry I didn't notice it earlier, @Puneet-here

@Puneet-here
Copy link
Contributor

No problem! Thanks for opening it again.

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@roryabraham
Copy link
Contributor

@johncschuster last TODO here is paying out the reporting bonus

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
@johncschuster
Copy link
Contributor

Thanks for the callout, @roryabraham! I'll apply the External label now so the job can be created.

@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Jun 20, 2023
@melvin-bot melvin-bot bot changed the title URL appears as html in thread title and alternate text in search page [$1000] URL appears as html in thread title and alternate text in search page Jun 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b674a204efbb9b04

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@johncschuster
Copy link
Contributor

Sorry for the ping, @sobitneupane. I applied the label just to have the job get created automatically. Nothing to do here!

@johncschuster
Copy link
Contributor

@Puneet-here I've just invited you to the job via Upwork. Can you ping me once you've accepted that?

@johncschuster
Copy link
Contributor

@Puneet-here friendly bump so I can issue you the reporting bonus!

@Puneet-here
Copy link
Contributor

Sorry for the delay. Just accepted the offer.

@johncschuster
Copy link
Contributor

Thanks! I've just issued payment!

@Puneet-here
Copy link
Contributor

Thanks. We can close the issue @johncschuster

@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

@johncschuster @roryabraham this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants