[$1000] DEV: The search field does not focus when selecting money request participants

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Mobile web browser at new.expensify.com (DEV not staging) on Android
2. Click on + icon and select request money option
3. enter amount and click on Next button
4. Notice the search field doesn't maintain focus.

Expected Result:

input field should be focused and keyboard should be opened on mobile

Actual Result:

keyboard open for a second and hides on mobile, input field does not maintain focus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome mobile web
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev v1.3.54-13
Reproducible in staging?: No
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230803_100237_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691037165176299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d1f88a241863e6bc
• Upwork Job ID: 1692290423533080576
• Last Price Increase: 2023-08-17
• Automatic offers:
• cubuspl42 | Reviewer | 26270465
• gadhiyamanan | Reporter | 26270468

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[GItGudRatio]

unable to repro

[Christinadobrzyn]

Can't reproduce asking for more testing - https://expensify.slack.com/archives/C049HHMV9SM/p1691791675458309?thread_ts=1691037165.176299&cid=C049HHMV9SM

[Christinadobrzyn]

I still can't reproduce - I'll follow this slack thread and we can still test but I can't reproduce this - https://expensify.slack.com/archives/C049HHMV9SM/p1692304707462269?thread_ts=1691037165.176299&cid=C049HHMV9SM

[Christinadobrzyn]

I was finally able to reproduce in Browserstack - using Galaxy s22, mobile web at https://new.expensify.com/.

Adding external label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d1f88a241863e6bc

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[Swor71]

Hey, I'm Marcin from Callstack - expert contributor group - I would like to help resolve this issue

[Christinadobrzyn]

Hey @cubuspl42 - let me know if having @Swor71 work on it is good! I can add the engineering label to move this along

[cubuspl42]

@Christinadobrzyn Sure, let's do that

[ayazhussain79]

Anyone able to reproduce this on dev or staging now?

[gadhiyamanan]

This is reproducible in staging and dev

[Swor71]

hey, apologies for lack of updates 🙏🏻 , I had some major issues with my setup but managed to sort it out and I am currently looking into this issue

[jasperhuangg]

This seems to also be happening on other platforms: #25803 I've updated to the OP to reflect this

[Swor71]

hey, PR for the fix - #25922, it turns out it's a simple change to allow for the transitions to play out before focusing the input. Tested this (and provided vids) on Chrome on Android, Safari on iOS and regular Chrome web browser

[situchan]

In this PR, I suggest to fix all pages across the app where auto focus don't work on some platforms as they have the same root cause.
i.e. Select a currency page

select.currency.mov

[situchan]

Why not generalize solution on all pages in this GH?
i.e. we can fix #26380 here

[cubuspl42]

@situchan From my perspective, because the work on the issue/PR is practically done and we've done it within the original scope.

[rushatgabhane]

Suggested an alternative approach here - #25922 (comment)

And I agree with @situchan that we should fix this for all pages. It doesn't make sense to create 5 issues that have the same root cause.

[parasharrajat]

We should fix all related pages together. I noticed the PR today and I had seen similar issues in the past. We should be targeting the root cause all the time.

[cubuspl42]

@Swor71 @luacmartins

Okey, so it seems that #27202 was a duplicate of #24314 (our issue), which wasn't caught up, and they "outrun" us.

I can't see any other path than closing this issue.

The only thing left out to figure out is the compensation. Speaking directly, I can't see how it's our fault that a duplicate wasn't classified as such. I'm open to hearing other perspectives.

[Swor71]

@cubuspl42 @luacmartins

I do agree that there is, realistically, no other course of action than to close this issue.

It's too bad that the dupe was not caught sooner as we've gone through 3 weeks of reviews and then the asked change to the approach just to be beat by one day before the merge :D but I guess that just happens sometimes ;)

Also, since I'm part of Callstack, I believe the compensation part is handled differently and shouldn't be an issue(?)

[luacmartins]

Yea, I agree. Let's close this issue. Thanks for all the work everyone and sorry it turned out like this.

[gadhiyamanan]

@Christinadobrzyn @luacmartins this is eligible for reporting bonus because it is reported first

[luacmartins]

Reopened for reporting bonus payment @Christinadobrzyn

[Christinadobrzyn]

Sorry, I'm a little lost on this one, are we just paying the reporter?

@luacmartins @cubuspl42

[Christinadobrzyn]

okay talked to @luacmartins who confirmed we're just paying the reporter because of the reported duplicate issue.

Payouts due:

Issue Reporter: $250 @gadhiyamanan (old pricing - paid in Upwork)
Contributor: NA
Contributor+: NA

Eligible for 50% #urgency bonus? NA

Upwork job is here. Posting is now closed so let me know if you need anything.